Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update event source icons #6158

Merged

Conversation

nemesis09
Copy link
Contributor

@nemesis09 nemesis09 commented Jul 30, 2020

Tracked by:
https://issues.redhat.com/browse/ODC-4354

Solution Description:
Update icons for Event Sources as per new UXD

Screens:

Screenshot from 2020-07-30 20-47-33

Screenshot from 2020-07-30 20-09-47

Screenshot from 2020-07-30 21-07-37

Test Coverage:
No new/updated tests

Browser Conformation:

  • Firefox
  • Chrome
  • Safari
  • Edge

Additional Info:
UXD

@nemesis09
Copy link
Contributor Author

cc @openshift/team-devconsole-ux

@nemesis09
Copy link
Contributor Author

/assign @invincibleJai

@invincibleJai
Copy link
Member

looks good to me !! @beaumorley needed your approval

@beaumorley
Copy link

This looks great.

One question @invincibleJai. Is Ping Source being removed? We did not create a new icon for Ping Source because we thought is was going away. If we are unsure when, I can create something temporary so it is not the same icon as Cron Job Source. LMK.

Thank you.

cc
@markito @serenamarie125

@invincibleJai
Copy link
Member

This looks great.

One question @invincibleJai. Is Ping Source being removed? We did not create a new icon for Ping Source because we thought is was going away. If we are unsure when, I can create something temporary so it is not the same icon as Cron Job Source. LMK.

Thank you.

cc
@markito @serenamarie125

Actually CronJob is deprecated but it's still there in Serverless operator so we show it, PingSource will be there

@invincibleJai
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020
@serenamarie125
Copy link
Contributor

Great improvements here, great job everyone!!

@andrewballantyne
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 73e21df into openshift:master Jul 30, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants