New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update event source icons #6158
update event source icons #6158
Conversation
cc @openshift/team-devconsole-ux |
/assign @invincibleJai |
looks good to me !! @beaumorley needed your approval |
This looks great. One question @invincibleJai. Is Ping Source being removed? We did not create a new icon for Ping Source because we thought is was going away. If we are unsure when, I can create something temporary so it is not the same icon as Cron Job Source. LMK. Thank you. |
Actually CronJob is deprecated but it's still there in Serverless operator so we show it, PingSource will be there |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, nemesis09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great improvements here, great job everyone!! |
/retest |
Tracked by:
https://issues.redhat.com/browse/ODC-4354
Solution Description:
Update icons for Event Sources as per new UXD
Screens:
Test Coverage:
No new/updated tests
Browser Conformation:
Additional Info:
UXD