Gherkin script for getting started #6167
Conversation
| @@ -0,0 +1,11 @@ | |||
| Feature: Create Sample Application | |||
| As a user I want to create the Sample Application from Add options | |||
There was a problem hiding this comment.
| As a user I want to create the Sample Application from Add options | |
| As a user, I want to create the Sample Application from +Add page |
There was a problem hiding this comment.
If you are okay then can you please update that sentence to:
| As a user I want to create the Sample Application from Add options | |
| As a user, I should be able to create the Sample Application from +Add page |
There was a problem hiding this comment.
I want has been used multiple times in other files and I think it is fine to use it here
There was a problem hiding this comment.
want is used in multiple files and it fits correctly so IMO there is no need to change it
| Scenario: Logging to openshift devconsole | ||
| Given user has devloper credentials | ||
| When user logins as a developer | ||
| Then user is taken to developer perspective directly |
There was a problem hiding this comment.
If user before logging out was in the developer perspective, then it will be taken to developer perspective. Can you please check whether they have added such feature. Also please add the new line.
There was a problem hiding this comment.
or we can start with user logging out from kubeadmin and then logging back in as a developer. WDYT about this?
There was a problem hiding this comment.
If you update to the above scenario, then you could change the background as well.
There was a problem hiding this comment.
When user login as a developer it will be taken to developer perspective which is part of the epic
There was a problem hiding this comment.
It is a new feature where when developer login( for the first time also) it will be taken to developer perspective directly, you can check the epic
| Feature: Create Sample Application | ||
| As a user I want to create the Sample Application from Add options | ||
|
|
||
| Background: |
There was a problem hiding this comment.
Need to update the background. User being developer can't be a background.
| @@ -0,0 +1,77 @@ | |||
| Feature: Getting Started tour of dev perspective | |||
There was a problem hiding this comment.
File Extension is missing. Please add it.
| @regression | ||
| Scenario: Quick tour when user logs in for the first time | ||
| Given user is in logging page for the first time | ||
| When user loggings to console |
There was a problem hiding this comment.
| When user loggings to console | |
| When user enters the credential | |
| And user clicks on the login button |
This makes more sense than your statement
| @@ -0,0 +1,42 @@ | |||
| Feature: Create Sample Application | |||
| As a user I want to create the Sample Application from Add options | |||
There was a problem hiding this comment.
| As a user I want to create the Sample Application from Add options | |
| As a user, I should be able to create the Sample Application from Add options |
There was a problem hiding this comment.
want is used in multiple files and it fits correctly so IMO there is no need to change it
| As a user I want to create the Sample Application from Add options | ||
|
|
||
| Background: | ||
| And user is in dev perspecitve |
There was a problem hiding this comment.
| And user is in dev perspecitve | |
| And user is at Developer perspecitve |
We have used this thing almost everywhere. It's better to use the same statement
|
|
||
| @regression | ||
| Scenario: Sample Card in Add flow | ||
| Given user is in Add flow of dev perspective |
There was a problem hiding this comment.
| Given user is in Add flow of dev perspective | |
| Given user is at +Add page |
| @regression | ||
| Scenario: Sample Card in Add flow | ||
| Given user is in Add flow of dev perspective | ||
| When user will see Samples card |
There was a problem hiding this comment.
We can remove this statement as it shouldn't be a When statement.
There was a problem hiding this comment.
It can be modified but can't be removed because it is the first time samples card gets the reference in +Add page
| And user will see builder image version dropdown | ||
| And user will see builder image below builder image version dropdown | ||
| And user will see git url is ineditable field | ||
| And user will see create and cancel button |
There was a problem hiding this comment.
Where is Then statement?
sanketpathak
force-pushed
the
gherkin_getting_started_ODC-3917
branch
from
09705f0
to
5aa4d47
Compare
There was a problem hiding this comment.
Please refer to this doc for button text or step text https://docs.google.com/document/d/1rOeUoPZV8vwzfH9h94WxpzbV-Bc-Qjhjvl3ABrJIUTQ/edit
| And user switches to developer perspective if not already there | ||
| And the Getting Started experience is automatically displayed | ||
| And user can see first screen as 'Welcome to Dev perspective' | ||
| And user can see the button labels on the first screen are 'Get Started' & 'Close' |
There was a problem hiding this comment.
| And user can see the button labels on the first screen are 'Get Started' & 'Close' | |
| And user can see the button labels on the first screen are 'Get Started' & 'Skip tour' |
| And user can see next screen appears on Search tab | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears on Command Line Terminal |
There was a problem hiding this comment.
This will only appear if Dev_Workspace is available/ flag is enabled
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears is Final Screen saying 'You are ready to go!' | ||
| And user can see the button labels as 'Got it' & 'Back to tour' |
There was a problem hiding this comment.
| And user can see the button labels as 'Got it' & 'Back to tour' | |
| And user can see the button labels as 'Okay, got it!' & 'Back' |
| And user can clicks on Next button | ||
| And user can see next screen appears is Final Screen saying 'You are ready to go!' | ||
| And user can see the button labels as 'Got it' & 'Back to tour' | ||
| And user can clicks on 'Got it' button |
There was a problem hiding this comment.
| And user can clicks on 'Got it' button | |
| And user can clicks on 'Okay, got it!' button |
| And user can see next screen appears is Final Screen saying 'You are ready to go!' | ||
| And user can see the button labels as 'Got it' & 'Back to tour' | ||
| And user can clicks on 'Got it' button | ||
| Then user is taken to Add view in developer perspective |
There was a problem hiding this comment.
guided tour doesn't redirect user to any page. user will be on the same page he started the tour on. By default, we load the topology page. So the user will be on topology page not add page.
| Scenario: Quick tour from help menu | ||
| Given user is in developer perspective | ||
| When user opens help menu on top right | ||
| And user clicks on 'Guided Tour' option | ||
| And the Getting Started experience is automatically displayed | ||
| And user can see first screen as 'Welcome to Dev perspective' | ||
| And user can see the button labels on the first screen are 'Get Started' & 'Close' | ||
| And user clicks on Get started | ||
| And user can see next screen appears on Perspective switcher | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears on Monitoring tab | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears on Search tab | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears on Command Line Terminal | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears on Help | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user can clicks on Next button | ||
| And user can see next screen appears is Final Screen saying 'You are ready to go!' | ||
| And user can see the button labels as 'Got it' & 'Back to tour' | ||
| And user can clicks on 'Got it' button | ||
| Then user is taken to Add view in developer perspective |
There was a problem hiding this comment.
Same as above. Please, look at the comments I added in the above regression.
| Given user is in developer perspective | ||
| When user opens help menu on top right | ||
| And user clicks on 'Guided Tour' option | ||
| And the Getting Started experience is automatically displayed |
There was a problem hiding this comment.
It's only automatically displayed on the first load of page. For this regression when user clicks the guided tour from help menu then it is started. I don't think we need this line
| And user can see next screen appears on Perspective switcher | ||
| And user can see the button labels as 'Next' & 'Back' | ||
| And user clicks on Back button | ||
| And user is taken to Add view in developer perspective |
There was a problem hiding this comment.
This regression is wrong. Clicking on the back button takes the user to the previous step not close the tour. When you are on any of the steps except Start and Finish. There is X button in the top right corner which can be used to close the tour. Once X is clicked a closing out modal will open.
sanketpathak
force-pushed
the
gherkin_getting_started_ODC-3917
branch
2 times, most recently
from
11c1b90
to
6792c1a
Compare
| @@ -0,0 +1,11 @@ | |||
| Feature: Create Sample Application | |||
There was a problem hiding this comment.
Feature and scenario description doesn't match
In this feature, there is only one scenario, so I don't think Background is required
In general, Background is used, when multiple scenarios has same given statement, so instead of writing it multiple times, at one place given statement is available
There was a problem hiding this comment.
If the feature name is Create Sample Application
I recommend to add one more scenario to create an application, If not please add login with kubeadmin as well and explain the outcome in the scenario
| Given user is developer | ||
|
|
||
| @regression | ||
| Scenario: Logging to openshift devconsole |
There was a problem hiding this comment.
Scenario : Developer perspective display on login to open shift application
Given user is at login page
When user enters the username as "username"
And password as "password"
And clicks login
Then user redirects to developer perspective
sanketpathak
force-pushed
the
gherkin_getting_started_ODC-3917
branch
from
6792c1a
to
22638bb
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: makambalaji, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Epic: https://issues.redhat.com/browse/ODC-3917
Story: https://issues.redhat.com/browse/ODC-4076