Monitoring: Use <dl> for popover help text #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
component/core
openshift-ci-robot
added
component/monitoring
|
/retest |
spadgett
reviewed
Jul 31, 2020
| @@ -1,5 +1,15 @@ | |||
| $tooltip-background-color: #151515; | |||
|
|
|||
| dl.inline { | |||
There was a problem hiding this comment.
I'd suggest a co- prefix so we never conflict with pf or another dependency.
We should either move this to a file like _common.scss or give it a BEM name for the monitoring view.
There was a problem hiding this comment.
Thanks @spadgett. Now renamed to co-inline and moved to _common.scss.
kyoto
force-pushed
the
monitoring-popover-dl
branch
from
066b1c0
to
28739f8
Compare
|
/retest |
1 similar comment
|
/retest |
spadgett
reviewed
Aug 3, 2020
These help texts are description lists, so <dl> is better for accessibility.
kyoto
force-pushed
the
monitoring-popover-dl
branch
from
28739f8
to
9a2fdc5
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These help texts are description lists, so
<dl>is better for accessibility.Do you prefer this approach @spadgett?