Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Browser: Remove unused namespace props #6173

Merged
merged 1 commit into from Aug 1, 2020
Merged

Query Browser: Remove unused namespace props #6173

merged 1 commit into from Aug 1, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jul 31, 2020

These namespace props are no longer needed because of changes to the
dev perspective Metrics page.

@kyoto
Query Browser: Remove unused namespace props
f51f9f4 
These `namespace` props are no longer needed because of changes to the
dev perspective Metrics page.
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2020
@dtaylor113
Copy link
Contributor

Cypress "no Watchdog alert" flake.
/retest

spadgett
spadgett approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 20bacfa into openshift:master Aug 1, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
@kyoto kyoto deleted the query-browser-remove-namespace branch August 2, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kyoto @dtaylor113 @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot