Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1861473: Watch ConsoleLinks so they update in the UI without refreshing #6180

Merged
merged 1 commit into from Aug 22, 2020
Merged

Bug 1861473: Watch ConsoleLinks so they update in the UI without refreshing #6180

merged 1 commit into from Aug 22, 2020

Conversation

rhamilto
Copy link
Member

@rhamilto rhamilto commented Jul 31, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Jul 31, 2020 •
edited

Need to revisit next week when I'm not working from a moving truck. :)

@rhamilto rhamilto changed the title [WIP]: Watch ConsoleLinks so they update in the UI without refreshing [WIP]: Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing Jul 31, 2020
@rhamilto rhamilto changed the title [WIP]: Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing [WIP] Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing Jul 31, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 4, 2020
@rhamilto rhamilto changed the title [WIP] Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing Aug 4, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2020
@rhamilto
Copy link
Member Author

rhamilto commented Aug 4, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@rhamilto: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto changed the title Bug 1861473 : Watch ConsoleLinks so they update in the UI without refreshing Bug 1861473: Watch ConsoleLinks so they update in the UI without refreshing Aug 4, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 4, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: This pull request references Bugzilla bug 1861473, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1861473: Watch ConsoleLinks so they update in the UI without refreshing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 4, 2020
spadgett
spadgett reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhamilto I think we either need to change how the topology watches links or hold a single global watch like we do for APIService

frontend/packages/dev-console/src/components/guided-tour/GuidedTourText.tsx Show resolved Hide resolved
frontend/packages/dev-console/src/components/topology/TopologyEdgePanel.tsx Outdated Show resolved Hide resolved
frontend/packages/dev-console/src/components/topology/components/nodes/WorkloadNode.tsx Outdated
Comment on lines 50 to 55
const [consoleLinks] = useK8sWatchResource<K8sResourceKind[]>({
isList: true,
kind: referenceForModel(ConsoleLinkModel),
});
const cheURL = getCheURL(consoleLinks);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to watch the one link with name che. But again I think we should avoid a separate watch for each node.

https://github.com/spadgett/console/blob/e47665c50e6f5ea842a2de42e88e60a3c2090452/frontend/packages/dev-console/src/components/topology/topology-utils.ts#L36-L37

frontend/public/components/dashboard/project-dashboard/project-dashboard.tsx Show resolved Hide resolved
@rhamilto
Copy link
Member Author

/hold

for broken merge queue

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2020
spadgett
spadgett approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @rhamilto 👍

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 18, 2020
@rhamilto
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@rhamilto
Copy link
Member Author

Rebase required. Please retag, @spadgett.

spadgett
spadgett approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

/hold

Needs rebase again :(

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@rhamilto
Copy link
Member Author

/hold cancel

Rebased. @spadgett, PTAL.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020
spadgett
spadgett approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Member Author

/hold for broken CI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2020
@rhamilto
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2020
@rhamilto
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94ec863 into openshift:master Aug 22, 2020
@openshift-ci-robot
Copy link
Contributor

@rhamilto: All pull requests linked via external trackers have merged: openshift/console#6180. Bugzilla bug 1861473 has been moved to the MODIFIED state.

In response to this:

Bug 1861473: Watch ConsoleLinks so they update in the UI without refreshing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhamilto rhamilto deleted the watch-console-links branch August 22, 2020 11:56
@spadgett spadgett added this to the v4.6 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rottencandy rottencandy Awaiting requested review from rottencandy

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rhamilto @openshift-ci-robot @spadgett @openshift-bot @christianvogt @openshift-merge-robot