Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show namespace table column when all projects is selected (for all admin workloads) #6181

Merged
merged 1 commit into from Aug 3, 2020
Merged

Only show namespace table column when all projects is selected (for all admin workloads) #6181

merged 1 commit into from Aug 3, 2020

Conversation

jcaianirh
Copy link
Member

Screen Shot 2020-07-31 at 5 24 29 PM

Screen Shot 2020-07-31 at 5 24 15 PM

only show namespace table col for all projects for:

pods, deployments, deployment configs (done in pr: #5799)
Stateful sets
secrets
config maps
cron jobs
jobs
daemon sets
replica sets
replication controllers
Horizontal pod autoscalers
Services
Routes,
Ingresses,
Network policies
Persistent volumen claims
Volume snapshots
Build config
Build
Image stream
Pipeline resources (done in pr: #5799)
Machines
Machine sets
Machine autoscalers
Machine health checks
Service Accounts
Resource quotas
Limit ranges

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 31, 2020
spadgett
spadgett approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2020
@spadgett
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2020
@jcaianirh
Copy link
Member Author

/retest

@jcaianirh
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2020
@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2020
@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/retest

@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2020
@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Aug 2, 2020

/hold

CI is consistently failing testing cron jobs.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2020
spadgett
spadgett reviewed Aug 2, 2020
View reviewed changes
frontend/public/components/cron-job.tsx Outdated
@@ -89,7 +90,7 @@ CronJobTableHeader.displayName = 'CronJobTableHeader';
const CronJobTableRow: RowFunction<CronJobKind> = ({ obj: cronjob, index, key, style }) => {
return (
<TableRow id={cronjob.metadata.uid} index={index} trKey={key} style={style}>
<TableData className={tableColumnClasses[0]}>
<TableData className={tableColumnClasses[0]} columnID="namespace">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column ID was added to the wrong column.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2020
spadgett
spadgett approved these changes Aug 2, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Aug 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2020
@spadgett
Copy link
Member

spadgett commented Aug 2, 2020

/retest

@spadgett
Copy link
Member

spadgett commented Aug 2, 2020

/refresh

@spadgett spadgett closed this Aug 2, 2020
@spadgett spadgett reopened this Aug 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2548357 into openshift:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaianirh @spadgett @openshift-bot @openshift-ci-robot @openshift-merge-robot