Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace choice to obc creation function #6203

Merged
merged 1 commit into from Aug 6, 2020
Merged

Add namespace choice to obc creation function #6203

merged 1 commit into from Aug 6, 2020

Conversation

ebondare
Copy link
Contributor

@ebondare ebondare commented Aug 4, 2020

No description provided.

@afreen23
Copy link
Contributor

afreen23 commented Aug 5, 2020

@ebondare can you specify in commit the way you made it stable.
It will help track. We can have many patches go by Make obc tests more stable , which will make us lose track of things.

Thanks for PR :)

@afreen23
Copy link
Contributor

afreen23 commented Aug 5, 2020

/retitle Add namespace choice to obc creation function
/lgtm

@openshift-ci-robot openshift-ci-robot changed the title Make obc tests more stable Add namespace choice to obc creation function Aug 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, ebondare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2020
@ebondare
Copy link
Contributor Author

ebondare commented Aug 5, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ebondare
Copy link
Contributor Author

ebondare commented Aug 5, 2020

/test e2e-gcp-console

1 similar comment
@ebondare
Copy link
Contributor Author

ebondare commented Aug 5, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Aug 5, 2020

/hold
Queue is broken. Hold for #6225

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@spadgett
Copy link
Member

spadgett commented Aug 5, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 13ce5c9 into openshift:master Aug 6, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/noobaa Related to noobaa-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ebondare @afreen23 @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot