Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change image stream dropdown labels #6218

Merged
merged 1 commit into from Aug 8, 2020
Merged

Change image stream dropdown labels #6218

merged 1 commit into from Aug 8, 2020

Conversation

jerolimov
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-2425

Analysis / Root cause:
There are a couple things that should be improved since this is a static field and not something dynamically created.

  • The title ImageStreams should have a space
  • The disabled dropdown shouldn't have an ellipsis to a predefined label ("Select Image Strea...")

Solution Description:
Changed the text of "Projects" to "Project" and ImageStreams to "Image Stream". I used singular because the user can select only one Project here. This matches also some other dropdown field labels, like "Application Name".

  • The text "Select Image Stream" was ellipsis on my Chrome and Firefox (both Fedora 32) only when the windows is smaller than 1024 pixels. I think this is "acceptable", or? @andrewballantyne

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux

Before:
before

After:
after

Unit test coverage report:
No tests changed

Test setup:

  • Create a Deployment from a container image with an external image (for example jerolimov/nodeinfo)
  • Open the Import from container image page again and select "Image stream tag from internal registry"

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 5, 2020
@jerolimov
Copy link
Member Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 5, 2020
@rottencandy
Copy link
Contributor

/lgtm
Tested locally, looks good

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
rohitkrai03
rohitkrai03 approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6ed70f3 into openshift:master Aug 8, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
@jerolimov jerolimov deleted the odc-2425 branch August 7, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@rottencandy rottencandy Awaiting requested review from rottencandy

@sahil143 sahil143 Awaiting requested review from sahil143

Assignees

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jerolimov @rottencandy @openshift-ci-robot @openshift-bot @rohitkrai03 @spadgett @openshift-merge-robot