Bug 1866033: Use Monaco APIs to set YAML editor value #6239
Conversation
|
@spadgett: This pull request references Bugzilla bug 1866033, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
openshift-ci-robot
added
the
approved
|
lgtm, but will wait for @rebeccaalpert to give final approval. |
Previously we were tracking the value in state, but this isn't necessary. We read the current value from the Monaco edit API already, and it caused a side effect of selecting the entire document on changes.
spadgett
force-pushed
the
yaml-editor-state
branch
from
9ac97d7
to
974cc43
Compare
|
I missed a reference to |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@spadgett: All pull requests linked via external trackers have merged: openshift/console#6239. Bugzilla bug 1866033 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously we were tracking the value in state, but this isn't
necessary. We read the current value from the Monaco edit API already,
and it caused a side effect of selecting the entire document on changes.
/assign @rebeccaalpert @rhamilto