Bug 1896101: Added negative tests for migration from VMWare and RHV

frontend/packages/kubevirt-plugin/integration-tests/tests/dialogs/diskDialog.ts

@@ -4,12 +4,13 @@ import {
   getSelectedOptionText,
   getSelectOptions,
   selectItemFromDropdown,
+  checkForError,
 } from '../utils/utils';
 import * as view from '../../views/dialogs/diskDialog.view';
 import { modalSubmitButton, saveButton } from '../../views/kubevirtUIResource.view';
 import { Disk, DiskSourceConfig } from '../types/types';
 import { diskAccessMode, DISK_SOURCE } from '../utils/constants/vm';
-import { waitForNoLoaders, modalCancelButton } from '../../views/wizard.view';
+import { waitForNoLoaders, modalCancelButton, errorHelper } from '../../views/wizard.view';
 import { browser, ExpectedConditions as until, $ } from 'protractor';
 
 export class DiskDialog {
@@ -39,6 +40,7 @@ export class DiskDialog {
 
   async fillName(name: string) {
     await fillInput(view.diskName, name);
+    return checkForError(errorHelper);
   }
 
   async fillSize(size: string) {

frontend/packages/kubevirt-plugin/integration-tests/tests/dialogs/networkInterfaceDialog.ts

@@ -1,13 +1,20 @@
 import { click, fillInput } from '@console/shared/src/test-utils/utils';
 import * as view from '../../views/dialogs/networkInterface.view';
-import { selectOptionByText, getSelectOptions, selectItemFromDropdown } from '../utils/utils';
+import {
+  selectOptionByText,
+  getSelectOptions,
+  selectItemFromDropdown,
+  checkForError,
+} from '../utils/utils';
 import { Network } from '../types/types';
 import { modalSubmitButton, saveButton } from '../../views/kubevirtUIResource.view';
 import { waitForNoLoaders } from '../../views/wizard.view';
+import * as wizardView from '../../views/importWizard.view';
 
 export class NetworkInterfaceDialog {
   async fillName(name: string) {
     await fillInput(view.nicName, name);
+    return checkForError(wizardView.errorHelper);
   }
 
   async selectModel(model: string) {

frontend/packages/kubevirt-plugin/integration-tests/tests/mocks/mocks.ts

@@ -457,3 +457,13 @@ export const datavolumeClonerClusterRole = {
   ],
 };
 deepFreeze(datavolumeClonerClusterRole);
+
+export const v2vUIDeployment = {
+  apiVersion: 'apps/v1',
+  kind: 'Deployment',
+  metadata: {
+    name: `v2v-vmware`,
+    namespace: testName,
+  },
+};
+deepFreeze(v2vUIDeployment);

frontend/packages/kubevirt-plugin/integration-tests/tests/models/importWizard.ts

@@ -5,8 +5,14 @@ import { click, asyncForEach } from '@console/shared/src/test-utils/utils';
 import { NetworkInterfaceDialog } from '../dialogs/networkInterfaceDialog';
 import { DiskDialog } from '../dialogs/diskDialog';
 import { tableRows, saveButton } from '../../views/kubevirtUIResource.view';
-import { selectOptionByText } from '../utils/utils';
-import { STORAGE_CLASS, VIRTUALIZATION_TITLE } from '../utils/constants/common';
+import { checkForError, getSelectOptions, selectOptionByText } from '../utils/utils';
+import {
+  IMPORT_WIZARD_CONN_NAME_PREFIX,
+  KEBAP_ACTION,
+  STORAGE_CLASS,
+  VIRTUALIZATION_TITLE,
+  VOLUME_MODE,
+} from '../utils/constants/common';
 import * as view from '../../views/importWizard.view';
 import { waitForNoLoaders, clickKebabAction } from '../../views/wizard.view';
 import { Wizard } from './wizard';
@@ -16,6 +22,7 @@ import { clickNavLink } from '@console/internal-integration-tests/views/sidenav.
 import { resourceHorizontalTab } from '../../views/uiResource.view';
 import { VirtualMachineTemplateModel, Network, Disk } from '../types/types';
 import { networkTabCol } from '../utils/constants/vm';
+import * as rhvView from '../../views/rhvImportWizard.view';
 
 export class ImportWizard extends Wizard {
   async openWizard(model: K8sKind) {
@@ -40,60 +47,97 @@ export class ImportWizard extends Wizard {
   }
 
   async confirmAndCreate() {
-    await click(view.importButon);
+    await click(view.importButton);
+  }
+
+  async selectInstanceByPrefixName(selector: any) {
+    const instanceFullName = (await getSelectOptions(selector)).find((option) =>
+      option.startsWith(IMPORT_WIZARD_CONN_NAME_PREFIX),
+    );
+    await selectOptionByText(selector, instanceFullName);
+    await this.waitForSpinner();
   }
 
   /**
    * Edits attributes of a NICs that are being imported from source VM.
    */
-  async updateImportedNICs() {
+  async updateNic(nic: Network) {
+    const nicDialog = new NetworkInterfaceDialog();
+    await clickKebabAction(nic.name, KEBAP_ACTION.Edit);
+    await waitForNoLoaders();
+    const networks = await nicDialog.getNetworks();
+    if (networks.length > 0) {
+      await nicDialog.selectNetwork(networks[networks.length - 1]);
+      const err = await checkForError(view.errorHelper);
+      if (err) {
+        return err;
+      }
+    } else {
+      throw Error('No available networks to assign imported NICs');
+    }
+    await click(view.confirmActionButton);
+    await waitForNoLoaders();
+    return null;
+  }
+
+  async getImportedNics() {
     const rows = await tableRows();
-    let importedNICs = rows.map((line) => {
-      const cols = line.split(/\t/);
+    return rows.map((line) => {
+      const cols = line.split(/\n/);
       return {
         name: cols[networkTabCol.name],
       };
     });
+  }
+
+  async updateImportedNICs() {
+    const importedNICs = await this.getImportedNics();
     // TODO: This is horrible, but unfortunately no better way to dynamically extract only device names
     // without using ElementArrayFinder, which on the other hand may cause NoStaleElement Exceptions
-    importedNICs = importedNICs.filter((_, i) => i % 3 === 0);
-
-    const NICDialog = new NetworkInterfaceDialog();
-    await asyncForEach(importedNICs, async (NIC) => {
-      await clickKebabAction(NIC.name, 'Edit');
-      await waitForNoLoaders();
-      const networks = await NICDialog.getNetworks();
-      if (networks.length > 0) {
-        await NICDialog.selectNetwork(networks[networks.length - 1]);
-      } else {
-        throw Error('No available networks to assign imported NICs');
-      }
-      await click(view.confirmActionButton);
-      await waitForNoLoaders();
+    // importedNICs = importedNICs.filter((_, i) => i % 11 === 0);
+    await asyncForEach(importedNICs, async (nic) => {
+      return this.updateNic(nic);
     });
   }
 
   /**
    * Edits attributes of Disks that are being imported from source VM.
    */
-  async updateImportedDisks() {
+
+  async updateDisk(disk: Disk) {
+    const diskDialog = new DiskDialog();
+    await clickKebabAction(disk.name, KEBAP_ACTION.Edit);
+    await waitForNoLoaders();
+    await diskDialog.selectStorageClass(STORAGE_CLASS);
+    // Configures volume mode if customized (block or filesystem)
+    if (VOLUME_MODE) {
+      await diskDialog.openAdvancedSettingsDrawer();
+      await diskDialog.selectVolumeMode(VOLUME_MODE);
+    }
+    const err = await checkForError(view.errorHelper);
+    if (err) {
+      return err;
+    }
+    await click(saveButton);
+    await waitForNoLoaders();
+    return null;
+  }
+
+  async getImportedDisks() {
     const rows = await tableRows();
-    let importedDisks = rows.map((line) => {
-      const cols = line.split(/\t/);
+    return rows.map((line) => {
+      const cols = line.split(/\n/);
       return {
         name: cols[networkTabCol.name],
         storageClass: STORAGE_CLASS,
       };
     });
-    importedDisks = importedDisks.filter((_, i) => i % 3 === 0);
+  }
 
-    const diskDialog = new DiskDialog();
+  async updateImportedDisks() {
+    const importedDisks = await this.getImportedDisks();
     await asyncForEach(importedDisks, async (disk) => {
-      await clickKebabAction(disk.name, 'Edit');
-      await waitForNoLoaders();
-      await diskDialog.selectStorageClass(disk.storageClass);
-      await click(saveButton);
-      await waitForNoLoaders();
+      await this.updateDisk(disk);
     });
   }
 
@@ -102,6 +146,37 @@ export class ImportWizard extends Wizard {
     await isLoaded();
   }
 
+  async importNetworkStep(config) {
+    const { networkResources } = config;
+    // Binding networks
+    // First update imported network interfaces to comply with k8s
+    await this.updateImportedNICs();
+    // Adding networks if any
+    if (networkResources) {
+      await this.addVmNetworks(networkResources);
+    }
+    await this.next();
+  }
+
+  async importDiskStep(config) {
+    const { storageResources } = config;
+    // Binding storage disks
+    // First update disks that come from the source VM
+    await this.updateImportedDisks();
+    // Adding disks if any
+    if (storageResources) {
+      await this.addVmStorage(storageResources);
+    }
+    await this.next();
+  }
+
+  async edit(config) {
+    const { advancedEdit } = config;
+    if (advancedEdit) {
+      click(rhvView.editButton);
+    }
+  }
+
   /**
    * Waits for loading icon on Import tab to disappear.
    * As the icon disappears and re-appears several times when loading VM details

frontend/packages/kubevirt-plugin/integration-tests/tests/models/rhvImportWizard.ts

@@ -8,6 +8,7 @@ import {
   IMPORT_WIZARD_CONN_TO_NEW_INSTANCE,
   RHV_WIZARD_CREATE_SUCCESS,
   PAGE_LOAD_TIMEOUT_SECS,
+  IMPORT_WIZARD_CONN_NAME_PREFIX,
 } from '../utils/constants/common';
 import * as view from '../../views/importWizard.view';
 import * as rhvView from '../../views/rhvImportWizard.view';
@@ -50,11 +51,14 @@ export class RhvImportWizard extends ImportWizard {
   }
 
   async configureInstance(instanceConfig: InstanceConfig) {
-    await selectOptionByText(rhvView.ovirtInstanceSelect, instanceConfig.instance);
     if (instanceConfig.instance === IMPORT_WIZARD_CONN_TO_NEW_INSTANCE) {
+      await selectOptionByText(rhvView.ovirtInstanceSelect, instanceConfig.instance);
       await this.configureProvider(instanceConfig);
+      await this.connectToInstance();
+    } else if (instanceConfig.instance.includes(IMPORT_WIZARD_CONN_NAME_PREFIX)) {
+      await this.selectInstanceByPrefixName(rhvView.ovirtInstanceSelect);
     } else {
-      throw Error('Saved provider instances are not implemented');
+      throw Error('No RHV instance was found');
     }
   }
 
@@ -73,24 +77,12 @@ export class RhvImportWizard extends ImportWizard {
     );
   }
 
-  async import(config: VMImportConfig) {
-    const {
-      provider,
-      instanceConfig,
-      name,
-      description,
-      sourceVMName,
-      storageResources,
-      networkResources,
-      startOnCreation,
-    } = config;
-    await this.openWizard(VirtualMachineModel);
-
-    // General section
+  async importVmConnectProviderStep(config) {
+    const { provider, instanceConfig, sourceVMName } = config;
+    // Establishing connection:
     await this.selectProvider(provider);
     await this.waitForSpinner();
     await this.configureInstance(instanceConfig);
-    await this.connectToInstance();
     await this.waitForSpinner();
 
     // Selecting RHV cluster
@@ -99,45 +91,36 @@ export class RhvImportWizard extends ImportWizard {
     await this.selectSourceVirtualMachine(sourceVMName);
     await this.waitForSpinner();
     // Clicking `edit` button to reach network and storage settings
-    await click(rhvView.editButton);
+    await this.edit(config);
+    await browser.sleep(2000);
     await click(view.nextButton);
-    await this.next();
+  }
+
+  async importVmConfigStep(config) {
+    const { name, description } = config;
     // Impossible to do changes of flavor, workload profile and/or OS, only VM name and description can be updated
     if (name) {
       await this.fillName(name);
     }
     if (description) {
       await this.fillDescription(description);
     }
-    await this.next();
-    // Binding networks
-    // First update imported network interfaces to comply with k8s
-    await this.updateImportedNICs();
-    // Adding networks if any
-    if (networkResources) {
-      await this.addVmNetworks(networkResources);
-    }
-    await this.next();
+    await click(view.nextButton);
+  }
 
-    // Binding storage disks
-    // First update disks that come from the source VM
-    await this.updateImportedDisks();
-    // Adding disks if any
-    if (storageResources) {
-      await this.addVmStorage(storageResources);
-    }
-    await this.next();
+  async import(config: VMImportConfig) {
+    const { name } = config;
+    await this.openWizard(VirtualMachineModel);
+
+    await this.importVmConnectProviderStep(config);
+    await this.importVmConfigStep(config);
+    await this.importNetworkStep(config);
+    await this.importDiskStep(config);
     // CloudInit page is in read-only mode
     await this.next();
-    // Additional devices page is in read-only mode
-    await this.next();
 
     // Review
-    await this.validateReviewTab(config);
-    if (startOnCreation) {
-      await this.startOnCreation();
-    }
-
+    await this.processReviewStep(config);
     // Import
     await this.confirmAndCreate();
     await this.waitForCreation();