Use fallback img for icon and add base64 img for tours #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitkrai03
force-pushed
the
quick-start-icon-fix
branch
from
0c98866
to
99e485e
Compare
serenamarie125
approved these changes
Aug 7, 2020
rohitkrai03
force-pushed
the
quick-start-icon-fix
branch
from
99e485e
to
84458bc
Compare
|
/assign @christianvogt |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/ODC-4433
Analysis / Root cause: The icon URL for quick start tour are not stable because the URL we are using is from operator bundles of
ServerlessandPipelinesoperator. This makes it not reachable fordeveloperuser and also not reachable in case the bundle is not available. Also, since the URL is specific to a version of the operator it will again break as soon as a new update of the operator comes in.Solution Description:
FallbackImgcomponent that falls back to a default image if thesrcof<img>is invalid or unreachable.<RouteIcon />as a default icon for quick starts.base64encoded images that are shipped with the CSV of the operator stored in a local file so it's not dependent on operators.Screen shots / Gifs for design review:
@openshift/team-devconsole-ux @bmignano
Browser conformance: