Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add create project link in all the dev console pages #6258

Merged
merged 1 commit into from Aug 11, 2020
Merged

Add create project link in all the dev console pages #6258

merged 1 commit into from Aug 11, 2020

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4448

Analysis / Root cause: Create project link was missing from project list page on Topology/Monitoring/Builds/Pipelines/Helm pages.

Solution Description: Use CreateProjectListPage instead of ProjectListPage in all pages.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux @parvathyvr

Peek 2020-08-07 01-37

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2020
parvathyvr
parvathyvr suggested changes Aug 7, 2020
View reviewed changes
Copy link

@parvathyvr parvathyvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rohitkrai03 ! I see that we have the same text as +Add page in all the other views.What we wanted to do was just append the " or create a project" to the existing text on the other views. Eg: For Topology "Select a project to view the topology or create a project"

@serenamarie125
Copy link
Contributor

Hi @rohitkrai03 ! I see that we have the same text as +Add page in all the other views.What we wanted to do was just append the " or create a project" to the existing text on the other views. Eg: For Topology "Select a project to view the topology or create a project"

Agreed - original text should remain, and just append "or create a project"

@rohitkrai03
Copy link
Contributor Author

rohitkrai03 commented Aug 7, 2020 •
edited

@parvathyvr @serenamarie125 I actually didn't change text for any of the pages. If you look at the diff in code you'll see that I am just using a different component which adds that functionality. I just didn't realize that the component which was earlier written for +Add page was hard coded with its text. Thanks for catching that. I've updated the PR, take a look at the updated gif below -

Peek 2020-08-07 20-33

@rohitkrai03
Copy link
Contributor Author

/retest

parvathyvr
parvathyvr approved these changes Aug 7, 2020
View reviewed changes
Copy link

@parvathyvr parvathyvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @rohitkrai03! LGTM

sahil143
sahil143 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified changes locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: parvathyvr, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 678b385 into openshift:master Aug 11, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
@rohitkrai03 rohitkrai03 deleted the create-project-link-fix branch July 24, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahil143 sahil143 sahil143 approved these changes

@parvathyvr parvathyvr parvathyvr approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rohitkrai03 @serenamarie125 @openshift-ci-robot @openshift-bot @sahil143 @parvathyvr @spadgett @openshift-merge-robot