Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1844944: Add default labels to default sc #6269

Merged
merged 1 commit into from Aug 10, 2020
Merged

Bug 1844944: Add default labels to default sc #6269

merged 1 commit into from Aug 10, 2020

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Aug 9, 2020

Add a "(default)" string to the default storage class option.

Screesnshots:
Before:
Screenshot from 2020-08-09 10-56-06

After:
Screenshot from 2020-08-09 11-09-19

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 9, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1844944, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1844944: Add default labels to default sc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2020
@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 9, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: This pull request references Bugzilla bug 1844944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 9, 2020
@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

@matthewcarleton please review

glekner
glekner suggested changes Aug 9, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/src/components/modals/disk-modal/disk-modal.tsx Outdated
@@ -539,16 +541,30 @@ export const DiskModal = withHandlePromise((props: DiskModalProps) => {
</FormSelect>
</FormRow>
{source.requiresStorageClass() && (
<K8sResourceSelectRow
<FormSelect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works but you lose the value that comes with K8sResourceSelectRow which is the loading state.
I suggest adding a generic defaultAnnotation prop to K8sResourceSelectRow and update the component to look for it in the annotations and if its there add (default) to the name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@yaacov yaacov force-pushed the add-default-labels-to-default-sc branch from e6fb200 to 285515f Compare August 9, 2020 09:10
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/shared Related to console-shared and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2020
@spadgett @yaacov
Bug 1866114: Don't store OpenAPI definitions in localStorage
a4d11d8 
The document is too large, so we hit browser limits for localStorage.
This can break Safari. Since the API server supports ETags for the
OpenAPI document, rely on browser caching instead.
@yaacov yaacov force-pushed the add-default-labels-to-default-sc branch from 285515f to a4d11d8 Compare August 9, 2020 09:11
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2020
@glekner
Copy link
Contributor

glekner commented Aug 9, 2020

nice!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

3 similar comments
@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Aug 9, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 89c8772 into openshift:master Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

@yaacov: All pull requests linked via external trackers have merged: openshift/console#6269, openshift/console#6125. Bugzilla bug 1844944 has been moved to the MODIFIED state.

In response to this:

Bug 1844944: Add default labels to default sc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner glekner requested changes

@rawagner rawagner Awaiting requested review from rawagner

@atiratree atiratree Awaiting requested review from atiratree

Assignees

@glekner glekner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @openshift-ci-robot @glekner @openshift-bot @spadgett @openshift-merge-robot