Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1867475: Gherkin Scripts for ODC-3325 #6272

Merged
merged 1 commit into from Aug 16, 2020
Merged

Bug 1867475: Gherkin Scripts for ODC-3325 #6272

merged 1 commit into from Aug 16, 2020

Conversation

gajanan-more
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4042

Problem: Gherkin Scripts Design for Knative Event Channel epic ODC-3325

Solution: These are the gherkin scripts designed covering all the scenarios related to Knative Event Channel epic ODC-3325

@openshift-ci-robot
Copy link
Contributor

@gajanan-more: This pull request references Bugzilla bug 1867475, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1867475: Gherkin Scripts for ODC-3325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 10, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 10, 2020
@gajanan-more
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

@gajanan-more: This pull request references Bugzilla bug 1867475, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gajanan-more
Copy link
Contributor Author

/assign @makambalaji @invincibleJai

@gajanan-more
Copy link
Contributor Author

/assign @karthikjeeyar

karthikjeeyar
karthikjeeyar reviewed Aug 10, 2020
View reviewed changes
frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/Knative/subscription-Channel-ODC-3225.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/Knative/subscription-Channel-ODC-3225.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/Knative/subscription-Channel-ODC-3225.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/Knative/subscription-Channel-ODC-3225.feature Outdated Show resolved Hide resolved
...ackages/dev-console/integration-tests/features/Knative/subscription-Channel-ODC-3225.feature Outdated Show resolved Hide resolved
@spadgett spadgett removed their request for review August 10, 2020 13:54
makambalaji
makambalaji reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following are my observations

  1. Include test data for the scenarios where ever applicable
  2. Include scenarios like multiple services to channel and multiple event sources linkage to channel etc..

frontend/packages/dev-console/integration-tests/features/Knative/channel-ODC-3225.feature Show resolved Hide resolved
@makambalaji
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@gajanan-more
Copy link
Contributor Author

/retest

@gajanan-more
Copy link
Contributor Author

/test e2e-gcp-console

@gajanan-more
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

22 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 99788a2 into openshift:master Aug 16, 2020
@openshift-ci-robot
Copy link
Contributor

@gajanan-more: Bugzilla bug 1867475 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1867475: Gherkin Scripts for ODC-3325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gajanan-more
Copy link
Contributor Author

/retest

@spadgett spadgett added this to the v4.6 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@makambalaji makambalaji makambalaji left review comments

@sanketpathak sanketpathak Awaiting requested review from sanketpathak

Assignees

@invincibleJai invincibleJai

@karthikjeeyar karthikjeeyar

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gajanan-more @openshift-ci-robot @makambalaji @openshift-bot @karthikjeeyar @spadgett @invincibleJai @openshift-merge-robot