Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add fake DBUS_SESSION_BUS_ADDRESS to improve CI reliability #6279

Merged
merged 1 commit into from Aug 11, 2020
Merged

tests: add fake DBUS_SESSION_BUS_ADDRESS to improve CI reliability #6279

merged 1 commit into from Aug 11, 2020

Conversation

spadgett
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
dtaylor113
dtaylor113 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit d47d080 into openshift:master Aug 11, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 11, 2020
@spadgett spadgett deleted the fake-dbus branch August 11, 2020 13:23
@spadgett spadgett mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

@rhamilto rhamilto Awaiting requested review from rhamilto

Assignees

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-ci-robot @dtaylor113 @openshift-merge-robot