Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1870606: Update error message for bootstrapServers and topics #6301

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1870606: Update error message for bootstrapServers and topics #6301

merged 1 commit into from Aug 20, 2020

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Aug 11, 2020 •
edited

Jira: https://issues.redhat.com/browse/ODC-4478

This PR updates error message for bootstrapServers and topics to make it more intuitive so that the user is aware that they can add bootstrapServers and topics manually irrespective of any error that occurred while fetching the existing ones and create a KafkaSource.

Screenshots
image

/kind bug

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Aug 11, 2020
@divyanshiGupta
Copy link
Contributor Author

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 11, 2020
@divyanshiGupta
Copy link
Contributor Author

@bgliwa01 WDYT?

cc: @invincibleJai

@bgliwa01
Copy link

One nit - add a period after manually

@divyanshiGupta
Copy link
Contributor Author

One nit - add a period after manually

Oops, sure.

@divyanshiGupta
Copy link
Contributor Author

@bgliwa01 done.

bgliwa01
bgliwa01 approved these changes Aug 12, 2020
View reviewed changes
Copy link

@bgliwa01 bgliwa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@invincibleJai
Copy link
Member

@divyanshiGupta/ @bgliwa01 can we have Try adding it manually even with initial text on place holder as user will still just see Error loading bootstrap Servers WDYT??

image

@divyanshiGupta
Copy link
Contributor Author

divyanshiGupta commented Aug 17, 2020 •
edited

@invincibleJai adding Try adding it manually at both places seems redundant. We can do one thing though, we can show the error directly in the input placeholder with Try adding bootstrapServers manually and keep the drop-down empty.
cc: @bgliwa01

rohitkrai03
rohitkrai03 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rohitkrai03
Copy link
Contributor

/lgtm cancel
/approve cancel

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2020
@invincibleJai
Copy link
Member

/lgtm
/approve

Thanks , works as expected based on discussion and agreed approach

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgliwa01, divyanshiGupta, invincibleJai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@invincibleJai
Copy link
Member

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@divyanshiGupta divyanshiGupta changed the title Update error message for bootstrapServers and topics Bug 1870606: Update error message for bootstrapServers and topics Aug 20, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: This pull request references Bugzilla bug 1870606, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870606: Update error message for bootstrapServers and topics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 00a4ac9 into openshift:master Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: All pull requests linked via external trackers have merged: openshift/console#6301. Bugzilla bug 1870606 has been moved to the MODIFIED state.

In response to this:

Bug 1870606: Update error message for bootstrapServers and topics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@bgliwa01 bgliwa01 bgliwa01 approved these changes

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@invincibleJai invincibleJai

@rohitkrai03 rohitkrai03

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/knative Related to knative-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@divyanshiGupta @bgliwa01 @invincibleJai @openshift-bot @rohitkrai03 @openshift-ci-robot @spadgett @openshift-merge-robot