Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1871767: Add quick start link in dashboard page #6305

Merged

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4454

Analysis / Root cause: There's no link to quick starts catalog from admin perspective.

Solution Description: Add a quick start link in dashboard page of admin perspective.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux @bmignano
image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Aug 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/dashboard Related to dashboard label Aug 11, 2020
@rohitkrai03
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor

@rohitkrai03 the user's pref for the visibility of this badge needs to be stored in local storage according to @bmignano

@rohitkrai03
Copy link
Contributor Author

@rohitkrai03 the user's pref for the visibility of this badge needs to be stored in local storage according to @bmignano

@christianvogt Updated PR to save user preference in local storage.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2020
@rohitkrai03 rohitkrai03 changed the title Add quick start link in dashboard page Bug 1871767: Add quick start link in dashboard page Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: This pull request references Bugzilla bug 1871767, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871767: Add quick start link in dashboard page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 42e0395 into openshift:master Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: All pull requests linked via external trackers have merged:

Bugzilla bug 1871767 has been moved to the MODIFIED state.

In response to this:

Bug 1871767: Add quick start link in dashboard page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 26, 2020
@rohitkrai03 rohitkrai03 deleted the quick-start-dashboard-link branch July 24, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants