Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1873140: fix Alert State filter for dev perspective Alerts #6313

Merged
merged 1 commit into from Sep 8, 2020
Merged

Bug 1873140: fix Alert State filter for dev perspective Alerts #6313

merged 1 commit into from Sep 8, 2020

Conversation

vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Aug 12, 2020 •
edited

Fix - https://issues.redhat.com/browse/ODC-4424

Screenshots
Kapture 2020-09-03 at 20 17 13

Test coverage
Screenshot 2020-08-27 at 6 45 29 PM

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Aug 12, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 12, 2020
@vikram-raj
Copy link
Member Author

/cc @kyoto

@kyoto
Copy link
Member

kyoto commented Aug 19, 2020

I realized that we should be making a similar change to the admin perspective too. I will take a look into that and consider if the two perspectives can share code for this fix.

@jerolimov
Copy link
Member

Could verify the fix on a cluster setup. Thanks @vikram-raj for providing some help and yaml files here. Will get a lgtm when you response to the open questions 😏

@kyoto
Copy link
Member

kyoto commented Aug 27, 2020

Opened a similar change for the admin perspective: #6460. The solutions will need to be different because the dev perspective combines rule rows and alert rows in the same table, but the admin perspective does not.

@vikram-raj
Copy link
Member Author

/retitle Bug 1873140: fix Alert State filter for dev perspective Alerts

@openshift-ci-robot openshift-ci-robot changed the title fix Alert State filter for dev perspective Alerts Bug 1873140: fix Alert State filter for dev perspective Alerts Aug 27, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Bugzilla bug 1873140, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873140: fix Alert State filter for dev perspective Alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 27, 2020
@openshift-ci-robot openshift-ci-robot added the component/monitoring Related to monitoring label Sep 3, 2020
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Bugzilla bug 1873140, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873140: fix Alert State filter for dev perspective Alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov
jerolimov approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and on an cluster (4.6.0-0.ci.test-2020-09-07-093240-ci-ln-fl8bwh2), works as expected. 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
jerolimov
jerolimov approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it again on 4.6.0-0.ci.test-2020-09-07-115219-ci-ln-qgpzqit

Thanks @vikram-raj for the support here :)

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
@kyoto
Copy link
Member

kyoto commented Sep 8, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, kyoto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit f71e06e into openshift:master Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: All pull requests linked via external trackers have merged:

Bugzilla bug 1873140 has been moved to the MODIFIED state.

In response to this:

Bug 1873140: fix Alert State filter for dev perspective Alerts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj deleted the odc-4424 branch September 8, 2020 07:11
@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@jerolimov jerolimov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vikram-raj @kyoto @jerolimov @openshift-ci-robot @spadgett @openshift-merge-robot