Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1882268: Add snapshots integration test #6314

Merged
merged 1 commit into from Dec 8, 2020
Merged

Bug 1882268: Add snapshots integration test #6314

merged 1 commit into from Dec 8, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Aug 12, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Aug 12, 2020
@yaacov
Copy link
Member

yaacov commented Aug 12, 2020

/retest

2 similar comments
@dtaylor113
Copy link
Contributor

/retest

@yaacov
Copy link
Member

yaacov commented Aug 13, 2020

/retest

atiratree
atiratree suggested changes Aug 13, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.snapshots.scenario.ts Outdated
});

afterAll(() => {
deleteResource(testVM);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we ensure that the snapshot gets deleted, for example when the status doe not get ready in time? We could use the leakableResources construct like other tests do

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.snapshots.scenario.ts Outdated

// TODO: add restore testing (right now not available in the API)

await click(editVMSnapshotsView.kebab);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use listViewAction instead?

@yaacov
Copy link
Member

yaacov commented Aug 17, 2020

/retest

1 similar comment
@yaacov
Copy link
Member

yaacov commented Aug 17, 2020

/retest

@glekner
Copy link
Contributor Author

glekner commented Aug 17, 2020

fixed suggestions @suomiy

glekner
glekner commented Aug 17, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/vm.snapshots.scenario.ts Outdated
});

it(
'ID() create, restore and delete a snapshot',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacov do we have test ID for this PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a question for @rhrazdil or @gouyang.

@rhrazdil , @gouyang do you know how to get/create a test ID ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to create the test case on polarion, if you can't do it in polarion, then I can help creating it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gouyang I'm not sure how to do it.. we need cases for CDI Upload, and Snapshots

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-4717.

Please use ID(CNV-4717).

atiratree
atiratree reviewed Aug 17, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/views/vm.snapshots.view.ts Outdated
import { $, $$ } from 'protractor';

export const addSnapshotBtn = $('#add-snapshot');
export const saveSnapshotBtn = $('#confirm-action');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 are not used anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addSnapshotBtn is used

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but snapshotKebab is not

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.snapshots.scenario.ts Outdated
// wait for snapshot to be ready
await browser.wait(
until.textToBePresentInElement(
editVMSnapshotsView.getStatusElement('test-snapshot'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could make a constant out of the name

@glekner glekner force-pushed the test-snapshots branch 2 times, most recently from 9782bec to f4ca9e1 Compare August 18, 2020 11:21
@yaacov
Copy link
Member

yaacov commented Aug 19, 2020

/retest

@glekner
Copy link
Contributor Author

glekner commented Aug 19, 2020

added test ID.
can you approve @suomiy

@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member

yaacov commented Aug 30, 2020

/retest

@glekner glekner changed the title Add snapshots integration test Bug 1882268: Add snapshots integration test Sep 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 24, 2020
@glekner
Copy link
Contributor Author

glekner commented Sep 24, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1882268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jelkosz
Copy link

jelkosz commented Sep 24, 2020

/hold - #6736 removed them for 4.6

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 54b0cf4 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2020
@glekner
Copy link
Contributor Author

glekner commented Oct 25, 2020

Added Restoring a snapshot to the Test.

@suomiy can you lgtm

@atiratree
Copy link
Member

can you please include this test in the CI?

@atiratree
Copy link
Member

ping @glekner

@glekner
Copy link
Contributor Author

glekner commented Oct 28, 2020

/retest

@glekner glekner force-pushed the test-snapshots branch 2 times, most recently from 28ae687 to f3a0e6a Compare November 1, 2020 10:07
@jelkosz
Copy link

jelkosz commented Dec 7, 2020

/hold cancel
its back in 4.7

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@glekner
Copy link
Contributor Author

glekner commented Dec 7, 2020

/test analyze

@yaacov
Copy link
Member

yaacov commented Dec 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 378b2b2 into openshift:master Dec 8, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: All pull requests linked via external trackers have merged:

Bugzilla bug 1882268 has been moved to the MODIFIED state.

In response to this:

Bug 1882268: Add snapshots integration test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouyang gouyang gouyang left review comments

@atiratree atiratree atiratree requested changes

@jelkosz jelkosz Awaiting requested review from jelkosz

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@glekner @yaacov @dtaylor113 @atiratree @openshift-bot @openshift-ci-robot @jelkosz @gouyang @spadgett @openshift-merge-robot