Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update JUnit report filenames #6327

Merged
merged 1 commit into from Aug 14, 2020
Merged

tests: update JUnit report filenames #6327

merged 1 commit into from Aug 14, 2020

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Aug 13, 2020 •
edited

JUnit reports must match pattern ./junit(_[^_]+)?(_\d+-\d+)?(_\d+)?\.xml$ to be found by ci-search.

/assign @dtaylor113
/cc @bparees

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@bparees
Copy link

bparees commented Aug 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@spadgett
tests: update JUnit test filenames
b6ce43d 
JUnit tests must match pattern `./junit(_[^_]+)?(_\d+-\d+)?(_\d+)?\.xml$`
to be found by ci-search.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
dtaylor113
dtaylor113 approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member Author

flake https://bugzilla.redhat.com/show_bug.cgi?id=1866296

/retest

@spadgett spadgett changed the title tests: update JUnit test filenames tests: update JUnit report filenames Aug 13, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8882140 into openshift:master Aug 14, 2020
@dtaylor113
Copy link
Contributor

/retest

@spadgett spadgett added this to the v4.6 milestone Aug 20, 2020
@spadgett spadgett deleted the junit-name branch August 24, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees

@bparees bparees

@dtaylor113 dtaylor113

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@spadgett @bparees @openshift-ci-robot @openshift-bot @dtaylor113 @openshift-merge-robot