Bug 1870636: Add ability to select unassigned as application filter in topology

[jeff-phillips-18]

Fixes
https://issues.redhat.com/browse/ODC-4447

Description
Add the Unassigned group to the list of filters for application groupings.

Screenshots

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug

/cc @bgliwa01

[christianvogt]

@jeff-phillips-18 import from GIT workflow still creates resources in an application instead of being unassigned.

[jeff-phillips-18]

@christianvogt Yeah. This is to add the ability to filter by Unassigned in the application drop down in the topology view.

I see. If unassigned is selected, it should create unassigned resources, thanks.

[bgliwa01]

Please change 'Unassigned' to be 'unassigned' in the dropdown, as well as the other locations we discussed.

[jeff-phillips-18]

@christianvogt Resources are now created as unassigned if the unassigned filter is set.

@bgliwa01 Changed Unassigned to unassigned in the dropdown as well as in the application selector (and help text) in the create flows.

Updated screenshots above.

[parvathyvr]

Hi @jeff-phillips-18 there are 2 points to change:

1. As per https://issues.redhat.com/browse/DTUX-84, we should have 'unassigned' after 'all applications' in the Applications dropdown in the secondary masthead.
2. Also in the General section of the forms,in the Application dropdown we should have the unassigned only once above the separator along with create application. We need not show it again in the application names after the separator.

[jeff-phillips-18]

@parvathyvr I have made those changes, updated the screenshots above

[rohitkrai03]

/assign

[rohitkrai03]

@jeff-phillips-18 Even if i go to git import form with application selected as unassigned, the app gets created in application name context. After digging into the code it seems this is happening due to GitSection using duplicate/wrong constant UNASSIGNED_KEY instead of UNASSIGNED_APPLICATIONS_KEY.

[openshift-ci-robot]

@jeff-phillips-18: This pull request references Bugzilla bug 1870636, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870636: Add ability to select unassigned as application filter in topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-phillips-18]

/bugzilla refresh

[openshift-ci-robot]

@jeff-phillips-18: This pull request references Bugzilla bug 1870636, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-phillips-18]

/bugzilla refresh

[openshift-ci-robot]

@jeff-phillips-18: This pull request references Bugzilla bug 1870636, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jeff-phillips-18]

@christianvogt Thanks. Fixed.

[jerolimov]

@jeff-phillips-18 When selecting Topology from the sidebar the application dropdown shows the right entries:

But when I'm already on the Topology graph and refresh the browser (with cmd-r or F5 or when entering the URL and press enter again), the application filter menu keeps empty also when the graph shows some applications:

When selecting another navigation entry and Topology again it works fine again.

edit: I noticed now that this bug already exist on the master. So this is not caused by your changes. Everything else lgtm. Should I create a new ticket for this finding Jeff?

Btw: Is it possible to show entry only if there is any node without assigned application?

[jeff-phillips-18]

I don't believe we intended the application filter to persist thru sessions as it is not part of the URL. That would be a request for change.

[jeff-phillips-18]

/retest

[jerolimov]

I don't believe we intended the application filter to persist thru sessions as it is not part of the URL. That would be a request for change.

Oh, I do not expected that the selection was saved. But sometimes the dropdown was not filled and I could not can select the app or your new "unassigned" (see 2nd screenshot above). On the new cluster it works now. I expect that there is an race condition that the application dropdown select was not updated always. As written in my "edit" note above this happen also on master so this does not block this issue here. I will keep an eye on this.

[jeff-phillips-18]

Btw: Is it possible to show entry only if there is any node without assigned application?

The only way to do this would be to load up the resources in the same manner as the topology view. Currently we retrieve all resources that could have the part-of label but not all of those resources are shown in the view or are considered to be belonging to an application or not. For instance pods and secrets.

[jerolimov]

/lgtm
/assign @rohitkrai03

[rohitkrai03]

@jeff-phillips-18 Got merge conflicts on this one.

[jeff-phillips-18]

@jerolimov Rebased, no other changes.

[jerolimov]

@jeff-phillips-18 Unfortunately I found another small issue while re-testing, sorry.

When I right click on a Deployment with an app name and select Edit Application Grouping and select "unassigned" in the modal (which was Unassigned before, but I think thats ok), the app name was changed to this name instead of 'none' app name.

[jeff-phillips-18]

which was Unassigned before, but I think thats ok

UX asked for it to be lowercased consistently during discussions about #6343 (comment)

[jerolimov]

Could verify "Edit Application Grouping" fix

/lgtm

[jeff-phillips-18]

/retest

[rohitkrai03]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-phillips-18, jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/console-shared/OWNERS [rohitkrai03]
• frontend/packages/dev-console/OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jeff-phillips-18: All pull requests linked via external trackers have merged:

• openshift/console#6343

Bugzilla bug 1870636 has been moved to the MODIFIED state.

In response to this:

Bug 1870636: Add ability to select unassigned as application filter in topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.