Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1866051: Effort to left align content filters so they are consistent with pf-c-toolbar #6356

Merged
merged 1 commit into from Aug 20, 2020
Merged

Bug 1866051: Effort to left align content filters so they are consistent with pf-c-toolbar #6356

merged 1 commit into from Aug 20, 2020

Conversation

sg00dwin
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 18, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1866051, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1866051: Effort to left align content filters so they are consistent with pf-c-toolbar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/core Related to console core functionality labels Aug 18, 2020
@openshift-ci-robot openshift-ci-robot added the component/monitoring Related to monitoring label Aug 18, 2020
@gdoyle1
Copy link

gdoyle1 commented Aug 18, 2020

@sg00dwin Looks great! Thanks for picking this up!

rhamilto
rhamilto reviewed Aug 18, 2020
View reviewed changes
frontend/public/components/RBAC/_rbac.scss Show resolved Hide resolved
frontend/public/components/cluster-settings/global-config.tsx Show resolved Hide resolved
frontend/public/components/cluster-settings/global-config.tsx Show resolved Hide resolved
frontend/public/components/RBAC/role.jsx Show resolved Hide resolved
frontend/public/components/cluster-settings/global-config.tsx Outdated
<div className="co-m-pane__filter-bar-group co-m-pane__filter-bar-group--help-text">
<div className="co-m-pane__body">
{!loading && (
<div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div>
<>

as you don't need an HTML element here.

@rhamilto
Copy link
Member

Screen Shot 2020-08-18 at 11 37 42 AM

Text input and button are misaligned < 768px.

@sg00dwin sg00dwin force-pushed the content-filter-consistency-alignment branch from e58affb to 74b3f9a Compare August 19, 2020 15:42
rhamilto
rhamilto approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sg00dwin
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: This pull request references Bugzilla bug 1866051, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 86c7ea2 into openshift:master Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged: openshift/console#6356. Bugzilla bug 1866051 has been moved to the MODIFIED state.

In response to this:

Bug 1866051: Effort to left align content filters so they are consistent with pf-c-toolbar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sg00dwin sg00dwin deleted the content-filter-consistency-alignment branch August 20, 2020 14:32
@spadgett spadgett added this to the v4.6 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sg00dwin @openshift-ci-robot @gdoyle1 @rhamilto @openshift-bot @spadgett @openshift-merge-robot