Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1874901: add utm_source parameter to Red Hat Marketplace URLs for attribution #6363

Merged
merged 5 commits into from Sep 18, 2020
Merged

Bug 1874901: add utm_source parameter to Red Hat Marketplace URLs for attribution #6363

merged 5 commits into from Sep 18, 2020

Conversation

gebhardtr
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Aug 18, 2020
@gebhardtr
Copy link
Member Author

/assign @spadgett

@robszumski
Copy link
Contributor

Looks good to me.

@spadgett
Copy link
Member

spadgett commented Sep 1, 2020

Sorry for the late review. If this needs to be merged for 4.6, we'll need a Bugzilla bug to make the bot happy.

@robszumski
Copy link
Contributor

Opened https://bugzilla.redhat.com/show_bug.cgi?id=1874901 but I forget how to link it up :)

@spadgett spadgett changed the title add utm_source parameter to Red Hat Marketplace URLs for attribution Bug 1874901: add utm_source parameter to Red Hat Marketplace URLs for attribution Sep 2, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 2, 2020
@openshift-ci-robot
Copy link
Contributor

@gebhardtr: This pull request references Bugzilla bug 1874901, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874901: add utm_source parameter to Red Hat Marketplace URLs for attribution

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2020
spadgett
spadgett approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Sep 4, 2020

/lgtm cancel

This appears to be causing a runtime error in OperatorHub, which is why it's not passing CI.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console/6363/pull-ci-openshift-console-master-e2e-gcp-console/1301810626204536832

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_console/6363/pull-ci-openshift-console-master-e2e-gcp-console/1301810626204536832/artifacts/e2e-gcp-console/gui_test_screenshots/4d05b387bbb1cb67e556361ee894f20b.png

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2020
@spadgett
Copy link
Member

spadgett commented Sep 4, 2020

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_console/6363/pull-ci-openshift-console-master-e2e-gcp-console/1301810626204536832/artifacts/e2e-gcp-console/gui_test_screenshots/browser.log

[SEVERE] https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js 159:71742 TypeError: Cannot read property 'marketplaceRemoteWorkflow' of null
    at OperatorHubTileView (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/operator-hub-chunk-b1d72e1ba5f91fe3085c.min.js:1:10650)
    at No (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:55337)
    at Ks (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:98261)
    at Bs (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:84008)
    at Fs (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:81035)
    at Ms (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:79608)
    at https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41759
    at t.unstable_runWithPriority (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:168:3878)
    at li (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41488)
    at hi (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41705)
[SEVERE] https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/main-chunk-b5ceb5290a313d6b1963.min.js 0:169527 TypeError: Cannot read property 'marketplaceRemoteWorkflow' of null
    at OperatorHubTileView (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/operator-hub-chunk-b1d72e1ba5f91fe3085c.min.js:1:10650)
    at No (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:55337)
    at Ks (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:98261)
    at Bs (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:84008)
    at Fs (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:81035)
    at Ms (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:79608)
    at https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41759
    at t.unstable_runWithPriority (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:168:3878)
    at li (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41488)
    at hi (https://console-openshift-console.apps.ci-op-1sx58hcd-75d12.origin-ci-int-gce.dev.openshift.com/static/vendors~main-chunk-fea3aedee736b735a490.min.js:160:41705)

spadgett
spadgett requested changes Sep 4, 2020
View reviewed changes
frontend/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-items.tsx Outdated
@@ -421,6 +421,16 @@ export const OperatorHubTileView: React.FC<OperatorHubTileViewProps> = (props) =
detailsItem &&
`/k8s/ns/${detailsItem.subscription.metadata.namespace}/${SubscriptionModel.plural}/${detailsItem.subscription.metadata.name}?showDelete=true`;

let remoteWorkflowUrl = detailsItem.marketplaceRemoteWorkflow;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like detailsItem is not always defined.

spadgett
spadgett reviewed Sep 11, 2020
View reviewed changes
frontend/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-items.tsx Outdated
@@ -421,6 +421,16 @@ export const OperatorHubTileView: React.FC<OperatorHubTileViewProps> = (props) =
detailsItem &&
`/k8s/ns/${detailsItem.subscription.metadata.namespace}/${SubscriptionModel.plural}/${detailsItem.subscription.metadata.name}?showDelete=true`;

let remoteWorkflowUrl = detailsItem && detailsItem.marketplaceRemoteWorkflow;
try {
const url = new URL(remoteWorkflowUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this tries to parse an undefined URL and spams the console with errors like

URL constructor: undefined is not a valid URL.

We should only try to parse the URL if defined. (Sorry I missed this on previous review.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I should have caught it. Thank you for the review!

spadgett
spadgett approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gebhardtr, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 910f7ce into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@gebhardtr: All pull requests linked via external trackers have merged:

Bugzilla bug 1874901 has been moved to the MODIFIED state.

In response to this:

Bug 1874901: add utm_source parameter to Red Hat Marketplace URLs for attribution

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gebhardtr @robszumski @spadgett @openshift-ci-robot @openshift-bot @openshift-merge-robot