Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1856353: Include installed version in operator hub item details #6401

Merged
merged 1 commit into from Aug 28, 2020
Merged

Bug 1856353: Include installed version in operator hub item details #6401

merged 1 commit into from Aug 28, 2020

Conversation

TheRealJon
Copy link
Member

Update operator hub item details to include the installed version when it is not the latest version.
Update "Operator Version" detail to "Latest Version" to convey that it is not the actual installed
version.

image

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Aug 21, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Bugzilla bug 1856353, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1856353: Include installed version in operator hub item details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 21, 2020
@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2020
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

This is a really expensive watch. CSVs contain a lot of data, and then they're copied across all namespaces. Are we able to wait until the user clicks the tile and get the single CSV we need to show the version?

@spadgett Looking into this, but I'm having issues with the details pane re-rendering very frequently. I'm trying to pinpoint the cause of that.

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2020
@TheRealJon TheRealJon changed the title Bug 1856353: Include installed version in operator hub item details [WIP] Bug 1856353: Include installed version in operator hub item details Aug 26, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2020
@TheRealJon TheRealJon changed the title [WIP] Bug 1856353: Include installed version in operator hub item details Bug 1856353: Include installed version in operator hub item details Aug 26, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 26, 2020
@TheRealJon
Copy link
Member Author

/hold

Depends on #6456

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020
@TheRealJon
Bug 1856353: Include installed version in operator hub item details
cfa104a 
Update operator hub item details to include the installed version when it is not the latest version.
Update "Operator Version" detail to "Latest Version" to convey that it is not the actual installed
version.
@TheRealJon
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
spadgett
spadgett approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TheRealJon
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 16243c8 into openshift:master Aug 28, 2020
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: All pull requests linked via external trackers have merged:

Bugzilla bug 1856353 has been moved to the MODIFIED state.

In response to this:

Bug 1856353: Include installed version in operator hub item details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 1, 2020
@TheRealJon TheRealJon deleted the 1856353-bz branch January 28, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@alecmerdler alecmerdler Awaiting requested review from alecmerdler

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TheRealJon @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot