New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1871866: Monitoring: Fix list style for the table pagination dropdowns #6409
Bug 1871866: Monitoring: Fix list style for the table pagination dropdowns #6409
Conversation
@kyoto: This pull request references Bugzilla bug 1871866, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -362,6 +362,10 @@ h6 { | |||
} | |||
} | |||
|
|||
.pf-c-pagination .pf-c-options-menu__menu { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is necessary for the same reason as given in the comment above (due to setting $pf-global--enable-reset to false
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Mind duplicating the comment?
@@ -362,6 +362,10 @@ h6 { | |||
} | |||
} | |||
|
|||
.pf-c-pagination .pf-c-options-menu__menu { | |||
list-style-type: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
list-style-type: none; | |
list-style: none; |
@@ -362,6 +362,10 @@ h6 { | |||
} | |||
} | |||
|
|||
.pf-c-pagination .pf-c-options-menu__menu { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Mind duplicating the comment?
74e36f3
to
995131d
Compare
@rhamilto Addressed your feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyoto, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@kyoto: All pull requests linked via external trackers have merged: openshift/console#6409. Bugzilla bug 1871866 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Affects the Monitoring UI, "Metrics" and "Dashboards" pages. These are the only pages using the PatternFly
Pagination
component.