Bug 1871895: Use form data for application ImageStream name #6410

rottencandy · 2020-08-24T14:42:53Z

Fixes:

https://issues.redhat.com/browse/ODC-4615
https://issues.redhat.com/browse/ODC-4649

Analysis / Root cause:

The add flow tries to get image name from imagestream labels, which may not be always present.

Solution Description:

Use application form data to get image stream name.

Screen shots / Gifs for design review:

Unit test coverage report:

Passing.

Browser conformance:

Chrome
Firefox
Safari
Edge

openshift-ci-robot · 2020-08-24T14:46:17Z

@rottencandy: This pull request references Bugzilla bug 1871895, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "4.6.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1871895: Use separate label for application ImageStream name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2020-08-24T14:47:37Z

/bugzilla refresh

openshift-ci-robot · 2020-08-24T14:47:44Z

@rottencandy: This pull request references Bugzilla bug 1871895, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rottencandy · 2020-08-24T14:56:32Z

/kind bug

sahil143 · 2020-08-24T15:12:32Z

frontend/packages/dev-console/src/components/edit-application/edit-application-utils.ts

@@ -239,6 +239,7 @@ export const getUserLabels = (resource: K8sResourceKind) => {
    'app.kubernetes.io/part-of',
    'app.openshift.io/runtime-version',
    'app.openshift.io/runtime-namespace',
+    'app.openshift.io/runtime-icon',


Please revert this change to use runtime label. runtime label itself points the imagestream icon.

Suggested change

'app.openshift.io/runtime-icon',

'app.openshift.io/runtime',

openshift-ci-robot · 2020-08-24T16:12:16Z

@rottencandy: This pull request references Bugzilla bug 1871895, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871895: Use separate label for application ImageStream name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143

Once in edit flow Image stream is not selected the first time dropdown is clicked.

divyanshiGupta · 2020-08-28T11:27:59Z

/lgtm

rottencandy · 2020-08-28T11:29:31Z

/lgtm

@divyanshiGupta I'm still working on Sahil's comment.

divyanshiGupta · 2020-08-28T11:35:24Z

/lgtm

@divyanshiGupta I'm still working on Sahil's comment.

Oops missed that. Let me know once you are done.
/lgtm cancel

divyanshiGupta

/lgtm

rottencandy · 2020-09-03T15:34:44Z

/assign @invincibleJai

openshift-ci-robot · 2020-09-04T11:05:44Z

@rottencandy: This pull request references Bugzilla bug 1871895, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871895: Use form data for application ImageStream name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

invincibleJai · 2020-09-04T14:37:55Z

frontend/packages/dev-console/src/components/import/image-search/ImageStreamNsDropdown.tsx

+      initialValues.imageStream.image &&
+      values.imageStream.image !== initialValues.imageStream.image
+    ) {
+      initialValues.imageStream.image = values.imageStream.image;


resetting initial values seems odd @rohitkrai03 @divyanshiGupta thoughts?

It's generally not recommended to change the initial values but here I think resetting the initial value is fine if this solves the issue since we just need the initial value only when the form is opened.

This effect gets fired the first time ImageStreamDropdown is changed, it's meant to verify the current namespace permissions, but ends up resetting the selected ImageStream name back to the initial value.

invincibleJai · 2020-09-07T07:57:25Z

/approve

Verified the changes , works as expected

/cc @karthikjeeyar

karthikjeeyar · 2020-09-07T08:26:36Z

Verified locally and it works fine.
/lgtm

openshift-ci-robot · 2020-09-07T08:26:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-07T08:43:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-07T08:58:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-07T13:02:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-07T14:20:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-07T18:53:52Z

@rottencandy: All pull requests linked via external trackers have merged:

openshift/console#6410

Bugzilla bug 1871895 has been moved to the MODIFIED state.

In response to this:

Bug 1871895: Use form data for application ImageStream name

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the component/dev-console Related to dev-console label Aug 24, 2020

openshift-ci-robot requested review from jeff-phillips-18 and nemesis09 August 24, 2020 14:43

rottencandy changed the title ~~Use separate label for application ImageStream name~~ Bug 1871895: Use separate label for application ImageStream name Aug 24, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 24, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 24, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 24, 2020

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 24, 2020

sahil143 suggested changes Aug 24, 2020

View reviewed changes

rottencandy force-pushed the isiedit branch from cc9aa4b to f09e644 Compare August 24, 2020 16:06

rottencandy changed the title ~~Bug 1871895: Use separate label for application ImageStream name~~ Bug 1871895: Use form data for application ImageStream name Aug 24, 2020

sahil143 suggested changes Aug 25, 2020

View reviewed changes

rottencandy force-pushed the isiedit branch from f09e644 to b0f1fc0 Compare August 27, 2020 16:16

openshift-ci-robot assigned divyanshiGupta Aug 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020

rottencandy force-pushed the isiedit branch 4 times, most recently from e4d729e to edc95ce Compare September 2, 2020 07:53

divyanshiGupta approved these changes Sep 3, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2020

openshift-ci-robot assigned invincibleJai Sep 3, 2020

invincibleJai reviewed Sep 4, 2020

View reviewed changes

use separate label for internal image streams

95b52fb

rottencandy force-pushed the isiedit branch from edc95ce to 95b52fb Compare September 7, 2020 07:23

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020

openshift-ci-robot requested a review from karthikjeeyar September 7, 2020 07:57

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2020

openshift-ci-robot assigned karthikjeeyar Sep 7, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020

openshift-merge-robot merged commit e7565ea into openshift:master Sep 7, 2020

rottencandy deleted the isiedit branch September 8, 2020 08:35

spadgett added this to the v4.6 milestone Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1871895: Use form data for application ImageStream name #6410

Bug 1871895: Use form data for application ImageStream name #6410

rottencandy commented Aug 24, 2020 •

edited

openshift-ci-robot commented Aug 24, 2020

rottencandy commented Aug 24, 2020

openshift-ci-robot commented Aug 24, 2020

rottencandy commented Aug 24, 2020

sahil143 Aug 24, 2020

rottencandy Aug 24, 2020

openshift-ci-robot commented Aug 24, 2020

sahil143 left a comment

divyanshiGupta commented Aug 28, 2020

rottencandy commented Aug 28, 2020

divyanshiGupta commented Aug 28, 2020

divyanshiGupta left a comment

rottencandy commented Sep 3, 2020

openshift-ci-robot commented Sep 4, 2020

invincibleJai Sep 4, 2020

divyanshiGupta Sep 4, 2020 •

edited

rottencandy Sep 4, 2020

invincibleJai commented Sep 7, 2020

karthikjeeyar commented Sep 7, 2020

openshift-ci-robot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-ci-robot commented Sep 7, 2020

Bug 1871895: Use form data for application ImageStream name #6410

Bug 1871895: Use form data for application ImageStream name #6410

Conversation

rottencandy commented Aug 24, 2020 • edited

openshift-ci-robot commented Aug 24, 2020

rottencandy commented Aug 24, 2020

openshift-ci-robot commented Aug 24, 2020

rottencandy commented Aug 24, 2020

sahil143 Aug 24, 2020

Choose a reason for hiding this comment

rottencandy Aug 24, 2020

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 24, 2020

sahil143 left a comment

Choose a reason for hiding this comment

divyanshiGupta commented Aug 28, 2020

rottencandy commented Aug 28, 2020

divyanshiGupta commented Aug 28, 2020

divyanshiGupta left a comment

Choose a reason for hiding this comment

rottencandy commented Sep 3, 2020

openshift-ci-robot commented Sep 4, 2020

invincibleJai Sep 4, 2020

Choose a reason for hiding this comment

divyanshiGupta Sep 4, 2020 • edited

Choose a reason for hiding this comment

rottencandy Sep 4, 2020

Choose a reason for hiding this comment

invincibleJai commented Sep 7, 2020

karthikjeeyar commented Sep 7, 2020

openshift-ci-robot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-bot commented Sep 7, 2020

openshift-ci-robot commented Sep 7, 2020

rottencandy commented Aug 24, 2020 •

edited

divyanshiGupta Sep 4, 2020 •

edited