Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1871901: Fix restart and review quickstart scenario according to UX #6411

Merged
merged 1 commit into from Aug 25, 2020

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4626

Analysis / Root cause: Restart/Resume the tour does not work if the side pane of another tour is open

Solution Description: Update restart/review based on latest UX.

Screen shots / Gifs for design review:

@openshift/team-devconsole-ux @serenamarie125 @bmignano @beaumorley

Peek 2020-08-24 20-20

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2020
@rohitkrai03 rohitkrai03 changed the title Update restart and review quickstart to latest UX Bug 1871901: Update restart and review quickstart to latest UX Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: This pull request references Bugzilla bug 1871901, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871901: Update restart and review quickstart to latest UX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitkrai03 rohitkrai03 changed the title Bug 1871901: Update restart and review quickstart to latest UX Bug 1871901: Fix restart and review quickstart scenario according to UX Aug 24, 2020
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and works fine.
Code would receive a lgtm from me, but wait for a lgtm from UX.

/test e2e-gcp-console

@jerolimov
Copy link
Member

One question for @openshift/team-devconsole-ux @serenamarie125 @bmignano @beaumorley:

When selecting a not-started quick start scenario and selecting the card and press "Start tour" on the left side (on the activated card) "nothing" happens. Is this fine for you?

@bmignano
Copy link

@jerolimov If I understand you correctly, clicking the card and the text both do the same action so if one has been done clicking the other doesn't do anything. If that is what you're referring to, I think that's okay.

@jerolimov
Copy link
Member

Okay, I think also its ok :)

/lgtm

@jerolimov
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f05932 into openshift:master Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: All pull requests linked via external trackers have merged: openshift/console#6411. Bugzilla bug 1871901 has been moved to the MODIFIED state.

In response to this:

Bug 1871901: Fix restart and review quickstart scenario according to UX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 26, 2020
@rohitkrai03 rohitkrai03 deleted the qs-restart-fix branch July 24, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants