Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1871925: Change name of "Show Groups" Toggle that switches the modes in topology #6413

Merged
merged 1 commit into from Aug 25, 2020
Merged

Bug 1871925: Change name of "Show Groups" Toggle that switches the modes in topology #6413

merged 1 commit into from Aug 25, 2020

Conversation

jeff-phillips-18
Copy link
Member

Fixes
https://issues.redhat.com/browse/ODC-4519

Description
Change topology view display options from Show Groups to a choice of modes: Connectivity and Consumption.

Screenshots
image

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

/kind bug

/cc @bgliwa01 @beaumorley @serenamarie125

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 24, 2020
@jeff-phillips-18 jeff-phillips-18 changed the title Bug 1871925 : Change name of "Show Groups" Toggle that switches the modes in topology Bug 1871925: Change name of "Show Groups" Toggle that switches the modes in topology Aug 24, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1871925, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871925: Change name of "Show Groups" Toggle that switches the modes in topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 24, 2020
@jeff-phillips-18
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Aug 24, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: This pull request references Bugzilla bug 1871925, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-phillips-18
Copy link
Member Author

/retest

1 similar comment
@jeff-phillips-18
Copy link
Member Author

/retest

invincibleJai
invincibleJai reviewed Aug 25, 2020
View reviewed changes
frontend/packages/dev-console/src/components/topology/filters/__tests__/FilterDropdown.spec.tsx
Comment on lines +87 to +88
// expect(radioButtons.at(0).prop('isChecked')).toBe(true);
// expect(radioButtons.at(1).prop('isChecked')).toBe(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can remove comments

@invincibleJai
Copy link
Member

Looks good , seems to works as expected

sahil143
sahil143 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified changes locally

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@invincibleJai
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
bgliwa01
bgliwa01 approved these changes Aug 25, 2020
View reviewed changes
Copy link

@bgliwa01 bgliwa01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgliwa01, invincibleJai, jeff-phillips-18, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

serenamarie125
serenamarie125 reviewed Aug 25, 2020
View reviewed changes
Copy link
Contributor

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks Jeff!

@openshift-merge-robot openshift-merge-robot merged commit 1452f80 into openshift:master Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@jeff-phillips-18: All pull requests linked via external trackers have merged:

Bugzilla bug 1871925 has been moved to the MODIFIED state.

In response to this:

Bug 1871925: Change name of "Show Groups" Toggle that switches the modes in topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 26, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the topology-modes branch December 2, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invincibleJai invincibleJai invincibleJai left review comments

@serenamarie125 serenamarie125 serenamarie125 left review comments

@sahil143 sahil143 sahil143 approved these changes

@bgliwa01 bgliwa01 bgliwa01 approved these changes

@beaumorley beaumorley Awaiting requested review from beaumorley

Assignees

@sahil143 sahil143

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jeff-phillips-18 @openshift-ci-robot @invincibleJai @openshift-bot @sahil143 @serenamarie125 @bgliwa01 @spadgett @openshift-merge-robot