Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1872279: Added e2e tests for ocs install for Attached Devices #6426

Merged
merged 1 commit into from Sep 4, 2020
Merged

Bug 1872279: Added e2e tests for ocs install for Attached Devices #6426

merged 1 commit into from Sep 4, 2020

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Aug 25, 2020 •
edited

Screenshot from 2020-08-25 18-40-26

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1872279, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872279: Added e2e tests for ocs install for Attached Devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Aug 25, 2020
@openshift-ci-robot openshift-ci-robot added component/lso Related to local-storage-operator-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2020
@gnehapk gnehapk force-pushed the bm-e2e branch 2 times, most recently from e55c361 to cb70e0a Compare August 25, 2020 12:45
@gnehapk
Copy link
Contributor Author

gnehapk commented Aug 25, 2020

Depends on #6404

@openshift-ci-robot
Copy link
Contributor

@gnehapk: This pull request references Bugzilla bug 1872279, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872279: Added e2e tests for ocs install for Attached Devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bipuladh
bipuladh suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use data-test rather than id

frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/src/components/ocs-install/ocs-request-data.ts Outdated Show resolved Hide resolved
...ges/local-storage-operator-plugin/src/components/local-volume-set/local-volume-set-inner.tsx Show resolved Hide resolved
...ges/local-storage-operator-plugin/src/components/local-volume-set/local-volume-set-inner.tsx Show resolved Hide resolved
@gnehapk gnehapk force-pushed the bm-e2e branch 3 times, most recently from dd999cf to 065da52 Compare September 3, 2020 05:52
bipuladh
bipuladh suggested changes Sep 3, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/tests/1-install/installFlow.scenario.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/utils/consts.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Outdated Show resolved Hide resolved
frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Outdated Show resolved Hide resolved
.../packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/state.ts Show resolved Hide resolved
@gnehapk gnehapk force-pushed the bm-e2e branch 2 times, most recently from 4cea597 to 213fe3c Compare September 4, 2020 07:21
bipuladh
bipuladh reviewed Sep 4, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/integration-tests/views/installFlow.view.ts Outdated
await browser.refresh();
await browser.wait(until.and(crudView.untilNoLoadersPresent), 100 * SECOND);
await click(currentSelectors.primaryButton);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@bipuladh
Copy link
Contributor

bipuladh commented Sep 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, gnehapk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 465109e into openshift:master Sep 4, 2020
@openshift-ci-robot
Copy link
Contributor

@gnehapk: All pull requests linked via external trackers have merged:

Bugzilla bug 1872279 has been moved to the MODIFIED state.

In response to this:

Bug 1872279: Added e2e tests for ocs install for Attached Devices

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh requested changes

@a2batic a2batic Awaiting requested review from a2batic

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/lso Related to local-storage-operator-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gnehapk @openshift-ci-robot @bipuladh @spadgett @openshift-merge-robot