Bug 1872092: Make 'Volume Snapshot *' labels consistent

[rhamilto]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1872092

Note I did not add Volume to Snapshot Class and Snapshot Content on the Volume Content and Volume Snapshot Content table headers in order to keep them shorter.

[openshift-ci-robot]

@rhamilto: This pull request references Bugzilla bug 1872092, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1872092: Make 'Volume Snapshot *' labels consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhamilto]

/bugzilla refresh

[openshift-ci-robot]

@rhamilto: This pull request references Bugzilla bug 1872092, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yapei]

@rhamilto Hi, trying to verify the fix before PR is merged

[yapei]

/bugzilla cc-qa

[openshift-ci-robot]

@yapei: This pull request references Bugzilla bug 1872092, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yapei]

1. on Create VolumeSnapshot form page, 'Volume Snapshot Class' dropdown shows 'Select volume snapshot class'
2. on Volume Snapshots Details page, it shows a field 'Volume Snapshot Class' and links with a 'vsc' icon
3. on Volume Snapshot Class Details page, the heading is shown as 'Volume Snapshot Class Details' , it shows a field 'Volume Snapshot Class' and links with a 'vsc' icon
4. on Volume Snapshot Content Details page, the heading is shown as 'Volume Snapshot Content Details' it shows a field 'Volume Snapshot Class' and links with a 'vsc' icon

But on Volume Snapshots lists page, the table heading is still showing Snapshot Class while it should be Volume Snapshot Class

[yapei]

[rhamilto]

But on Volume Snapshots lists page, the table heading is still showing Snapshot Class while it should be Volume Snapshot Class

@yapei, as noted above, I intentionally left the table header instances unchanged due to the length of the labels. Adding Volume makes those column headers significantly longer, making the table columns narrower. If you feel strongly, I'm happy to change it, but we may need to drop a right-most column or two at various viewport sizes.

[yapei]

yeah you are right, I just forgot about that sentence. Sorry

[yapei]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@rhamilto: All pull requests linked via external trackers have merged:

• openshift/console#6429

Bugzilla bug 1872092 has been moved to the MODIFIED state.

In response to this:

Bug 1872092: Make 'Volume Snapshot *' labels consistent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.