Bug 1873623: Revert of add label changes in #5998 #6440

andrewballantyne · 2020-08-25T20:44:32Z

Revert of partial changes in #5998 (returning the add labels).

https://issues.redhat.com/browse/ODC-4646

Screenshots

FYI @bgliwa01 / @beaumorley

/cc @debsmita1

andrewballantyne · 2020-08-25T20:46:07Z

/auto-cc

debsmita1 · 2020-08-28T10:19:24Z

...es/console-shared/src/components/formik-fields/multi-column-field/MultiColumnFieldFooter.tsx

@@ -20,7 +20,7 @@ const MultiColumnFieldFooter: React.FC<MultiColumnFieldHeader> = ({
    icon={<PlusCircleIcon />}
    isInline
  >
-    {addLabel || 'Add'}
+    {addLabel || 'Add values'}


how about Add value ?

I reverted the change where you removed this value. I didn't customize the text.

debsmita1 · 2020-08-28T10:23:57Z

frontend/packages/dev-console/src/components/health-checks/RequestTypeForms.tsx

@@ -104,6 +105,7 @@ export const CommandRequestTypeForm: React.FC<RequestTypeFormProps> = ({ probeTy
    <TextColumnField
      name={`healthChecks.${probeType}.data.exec.command`}
      label="Command"
+      addLabel="Add command"


should we go with the first letter of every word in caps or the first letter of the text in caps? better to follow a single pattern

Again, same thing - just a revert of what it was before you removed it.

debsmita1 · 2020-08-28T10:25:25Z

...d/packages/dev-console/src/components/pipelines/pipeline-builder/task-sidebar/temp-utils.tsx

@@ -87,6 +87,7 @@ export const ArrayParam: React.FC<ParameterProps> = (props) => {
        {description}
      </p>
      <MultiColumnFieldFooter
+        addLabel="Add another value"


how about add value ?

Same thing here, the value before it was removed.

andrewballantyne

I don't really disagree with you @debsmita1 but I would like this PR to be just the revert of what it was... not a revert and customize. It'll confuse the intent.

We could log a followup ticket to customize the text if we think it's important enough, but I want the change log for this change to be "undo" in the purest of forms it can be.

andrewballantyne · 2020-08-28T18:50:34Z

...es/console-shared/src/components/formik-fields/multi-column-field/MultiColumnFieldFooter.tsx

@@ -20,7 +20,7 @@ const MultiColumnFieldFooter: React.FC<MultiColumnFieldHeader> = ({
    icon={<PlusCircleIcon />}
    isInline
  >
-    {addLabel || 'Add'}
+    {addLabel || 'Add values'}


I reverted the change where you removed this value. I didn't customize the text.

andrewballantyne · 2020-08-28T18:51:18Z

frontend/packages/dev-console/src/components/health-checks/RequestTypeForms.tsx

@@ -104,6 +105,7 @@ export const CommandRequestTypeForm: React.FC<RequestTypeFormProps> = ({ probeTy
    <TextColumnField
      name={`healthChecks.${probeType}.data.exec.command`}
      label="Command"
+      addLabel="Add command"


Again, same thing - just a revert of what it was before you removed it.

andrewballantyne · 2020-08-28T18:53:16Z

...d/packages/dev-console/src/components/pipelines/pipeline-builder/task-sidebar/temp-utils.tsx

@@ -87,6 +87,7 @@ export const ArrayParam: React.FC<ParameterProps> = (props) => {
        {description}
      </p>
      <MultiColumnFieldFooter
+        addLabel="Add another value"


Same thing here, the value before it was removed.

openshift-ci-robot · 2020-08-28T19:20:27Z

@andrewballantyne: This pull request references Bugzilla bug 1873623, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1873623: Revert of add label changes in #5998

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-09-01T15:06:35Z

@debsmita1 We have a follow up ticket to cleanup the labels.
https://issues.redhat.com/browse/ODC-4700

debsmita1 · 2020-09-02T09:00:44Z

/lgtm

andrewballantyne · 2020-09-02T11:54:39Z

/assign @rohitkrai03 @christianvogt

rohitkrai03

/approve

openshift-ci-robot · 2020-09-02T13:22:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, debsmita1, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-02T16:04:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-02T16:17:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-02T20:54:03Z

@andrewballantyne: All pull requests linked via external trackers have merged:

openshift/console#6440

Bugzilla bug 1873623 has been moved to the MODIFIED state.

In response to this:

Bug 1873623: Revert of add label changes in #5998

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Revert of add label changes in openshift#5998

8268aef

openshift-ci-robot requested a review from debsmita1 August 25, 2020 20:44

openshift-ci-robot requested review from abhi-kn and spadgett August 25, 2020 20:46

debsmita1 reviewed Aug 28, 2020

View reviewed changes

andrewballantyne commented Aug 28, 2020

View reviewed changes

andrewballantyne changed the title ~~[WIP] Revert of add label changes in #5998~~ Bug 1873623: Revert of add label changes in #5998 Aug 28, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 28, 2020

andrewballantyne requested a review from debsmita1 September 1, 2020 15:06

openshift-ci-robot assigned debsmita1 Sep 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020

openshift-ci-robot assigned christianvogt and rohitkrai03 Sep 2, 2020

rohitkrai03 approved these changes Sep 2, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020

openshift-merge-robot merged commit 3d0c33e into openshift:master Sep 2, 2020

spadgett added this to the v4.6 milestone Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1873623: Revert of add label changes in #5998 #6440

Bug 1873623: Revert of add label changes in #5998 #6440

andrewballantyne commented Aug 25, 2020 •

edited

andrewballantyne commented Aug 25, 2020

debsmita1 Aug 28, 2020

andrewballantyne Aug 28, 2020

debsmita1 Aug 28, 2020

andrewballantyne Aug 28, 2020

debsmita1 Aug 28, 2020

andrewballantyne Aug 28, 2020

andrewballantyne left a comment

andrewballantyne Aug 28, 2020

andrewballantyne Aug 28, 2020

andrewballantyne Aug 28, 2020

openshift-ci-robot commented Aug 28, 2020

andrewballantyne commented Sep 1, 2020

debsmita1 commented Sep 2, 2020

andrewballantyne commented Sep 2, 2020

rohitkrai03 left a comment

openshift-ci-robot commented Sep 2, 2020

openshift-bot commented Sep 2, 2020

openshift-bot commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

Bug 1873623: Revert of add label changes in #5998 #6440

Bug 1873623: Revert of add label changes in #5998 #6440

Conversation

andrewballantyne commented Aug 25, 2020 • edited

Screenshots

andrewballantyne commented Aug 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 28, 2020

andrewballantyne commented Sep 1, 2020

debsmita1 commented Sep 2, 2020

andrewballantyne commented Sep 2, 2020

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 2, 2020

openshift-bot commented Sep 2, 2020

openshift-bot commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

andrewballantyne commented Aug 25, 2020 •

edited