Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 #6442

sanketpathak · 2020-08-25T22:50:47Z

Gherkin script for the HPA -Add, Edit and Delete
Epic: https://issues.redhat.com/browse/ODC-3556
Story: https://issues.redhat.com/browse/ODC-4339

gajanan-more

You haven't added the file extension to any file. Can you please add it? Also create bugzilla and add it here.

openshift-ci-robot · 2020-08-26T09:36:43Z

@sanketpathak: This pull request references Bugzilla bug 1872644, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gajanan-more

Please update the suggested changes.

...console/integration-tests/features/topology/horizonta_pod_autoscaling/Add_HPA_Action.feature

...onsole/integration-tests/features/topology/horizonta_pod_autoscaling/Edit_HPA_Action.feature

...console/integration-tests/features/topology/horizonta_pod_autoscaling/Add_HPA_Action.feature

gajanan-more · 2020-08-27T13:16:40Z

...onsole/integration-tests/features/topology/horizonta_pod_autoscaling/Edit_HPA_Action.feature

+   And user checks the YAML
+   And user changes values of cpu and memory under metrics.resource.target.averageUtilization
+   And user changes minimum and maximum pods value in minReplicas and maxReplicas
+   And user edits the name value under metadata.name


So you can't edit the name from Form view but you can edit it from YAML view, right?

It can be edited but you can't save it as the name should not be changed

Are you able to save the changed name through YAML? If yes, then don't you think it's a bug? Can you please confirm it from Andrew?

...ntegration-tests/features/topology/horizonta_pod_autoscaling/HPA _Topology_&_Sidebar.feature

gajanan-more · 2020-08-28T09:59:23Z

/lgtm

andrewballantyne

You seem to (unless I missed it) not cover what if the user doesn't set the cpu / memory limits and the disabled form.

andrewballantyne · 2020-08-28T17:15:02Z

...console/integration-tests/features/topology/horizonta_pod_autoscaling/Add_HPA_Action.feature

+   And user selects on resource tab
+   Then user can see two pods under pod section
+   And user can see Horizontal Pod Autoscalers section
+   And user can see the example with HPA tag associated present under HPA section


Suggested change

And user can see the example with HPA tag associated present under HPA section

And user can see the 'example' with HPA tag associated present under HPA section

Thoughts? example is a bad word imo for tests, because I read this as "an example" rather than "the 'example' named resource"

andrewballantyne · 2020-08-28T17:18:59Z

...onsole/integration-tests/features/topology/horizonta_pod_autoscaling/Edit_HPA_Action.feature

+    And user has created a deployment 
+    And user has added CPU resource limit
+    And user has added Memory resource limit
+    And user is in topology


And user has created an HPA on this deployment?

None of the edit flows make sense without this pre-step

I've included this in the given statement of the scenarios

I understand that, but what's the purpose of a background if not to reduce repeat?

andrewballantyne · 2020-08-28T17:26:49Z

...integration-tests/features/topology/horizonta_pod_autoscaling/HPA_Topology_&_Sidebar.feature

+    And user has a workload with HPA assigned to it
+
+@regression @manual
+Scenario: Changes due to HPA in Workload Sidebar


We should also check that there is also no set pod count in the actions.

Yeah, I'm checking for Edit Pod Count option in the action menu

Must have missed it.

andrewballantyne · 2020-08-28T17:27:24Z

...integration-tests/features/topology/horizonta_pod_autoscaling/HPA_Topology_&_Sidebar.feature

+   And user clicks on details tab
+   Then user can see the scaling of the pod disabled
+   And user can see the arrows to increase and decrease pods are not present
+   And user can see 'Autoscaling to' inside the pod donut


I wouldn't tie to this text, it should settle when the HPA cleans up. And thus this may say 'Autoscaled to'.

Fair enough I'll edit it

andrewballantyne

/lgtm

You should get Balaji to give the approval.

makambalaji · 2020-09-01T14:36:23Z

...console/integration-tests/features/topology/horizonta_pod_autoscaling/Add_HPA_Action.feature

+   And user adds name 'example' 
+   And user assigns minimum pods value to 2 
+   And user assigns maximum pods value to 5
+   And user gives CPU Utilizationvalue as 60
+   And user gives Memory Utilization value as 30


Include the test data in ""

makambalaji

Scenarios looks good, make sure below acceptance criteria is added
As a user, when i create an HPA from the HPA page in the Admin perspective, I should be brought to the YAML editor with default YAML aligned with v2beta2
As a user, I want to Search for HPAs, click on the Create button and be brought to the YAML editor with default YAML aligned with v2beta2

Please note: Add test data wherever aplicable

makambalaji · 2020-09-01T14:37:59Z

...console/integration-tests/features/topology/horizonta_pod_autoscaling/Add_HPA_Action.feature

+   And user assigns name value as example
+   And user gives value to averageUtilization under cpu target as 60


Add test data in ""

makambalaji · 2020-09-01T14:45:00Z

...onsole/integration-tests/features/topology/horizonta_pod_autoscaling/Edit_HPA_Action.feature

+
+@regression
+Scenario: Edit HPA action form view
+   Given user has a workload with HPA assigned to it


Include the test data wherever applicable i.e, workload as below
user has a workload "nodejs-ex-git-1" with HPA assigned to it

makambalaji · 2020-09-01T14:46:03Z

...onsole/integration-tests/features/topology/horizonta_pod_autoscaling/Edit_HPA_Action.feature

+   And user checks and edit the cpu value
+   And user checks and edit the memory value


Add test data for cpu, memory values

makambalaji · 2020-09-04T14:22:17Z

/approve

makambalaji · 2020-09-04T14:26:24Z

/lgtm

openshift-ci-robot · 2020-09-04T14:26:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, gajanan-more, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/integration-tests/OWNERS~~ [andrewballantyne,makambalaji]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-04T16:19:35Z

@sanketpathak: All pull requests linked via external trackers have merged:

openshift/console#6442

Bugzilla bug 1872644 has been moved to the MODIFIED state.

In response to this:

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the component/dev-console Related to dev-console label Aug 25, 2020

openshift-ci-robot requested review from gajanan-more and jeff-phillips-18 August 25, 2020 22:51

gajanan-more reviewed Aug 26, 2020

View reviewed changes

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch from ffa1cad to c0b6b2e Compare August 26, 2020 09:06

sanketpathak changed the title ~~gherkin script for HPA-add,edit an delete-ODC-3556~~ Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 Aug 26, 2020

openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 26, 2020

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch 3 times, most recently from ece1d12 to 3f7be81 Compare August 26, 2020 17:45

gajanan-more suggested changes Aug 27, 2020

View reviewed changes

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch 3 times, most recently from 20daa0e to 945001d Compare August 27, 2020 12:26

gajanan-more suggested changes Aug 27, 2020

View reviewed changes

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch 4 times, most recently from e13801c to 9c8c852 Compare August 28, 2020 09:56

openshift-ci-robot assigned gajanan-more Aug 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020

andrewballantyne suggested changes Aug 28, 2020

View reviewed changes

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch from 9c8c852 to f265111 Compare August 28, 2020 21:12

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020

andrewballantyne reviewed Aug 28, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Aug 28, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2020

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2020

makambalaji reviewed Sep 1, 2020

View reviewed changes

gherkin script for HPA-add,edit an delete-ODC-3556

6caea33

sanketpathak force-pushed the gherkin-hpa-ODC-3556 branch from f265111 to 6caea33 Compare September 3, 2020 11:04

openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 3, 2020

openshift-ci-robot assigned makambalaji Sep 4, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2020

openshift-merge-robot merged commit 96ecdbb into openshift:master Sep 4, 2020

spadgett added this to the v4.6 milestone Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 #6442

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 #6442

sanketpathak commented Aug 25, 2020

gajanan-more left a comment

openshift-ci-robot commented Aug 26, 2020

gajanan-more left a comment

gajanan-more Aug 27, 2020

sanketpathak Aug 27, 2020

gajanan-more Aug 28, 2020

gajanan-more commented Aug 28, 2020

andrewballantyne left a comment

andrewballantyne Aug 28, 2020

sanketpathak Aug 28, 2020

andrewballantyne Aug 28, 2020

sanketpathak Aug 28, 2020

andrewballantyne Aug 28, 2020

andrewballantyne Aug 28, 2020

sanketpathak Aug 28, 2020

andrewballantyne Aug 28, 2020

andrewballantyne Aug 28, 2020

sanketpathak Aug 28, 2020

andrewballantyne left a comment

makambalaji Sep 1, 2020

makambalaji left a comment

makambalaji Sep 1, 2020

makambalaji Sep 1, 2020

makambalaji Sep 1, 2020

makambalaji commented Sep 4, 2020

makambalaji commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

	And user can see the example with HPA tag associated present under HPA section
	And user can see the 'example' with HPA tag associated present under HPA section

		And user assigns name value as example
		And user gives value to averageUtilization under cpu target as 60

		And user checks and edit the cpu value
		And user checks and edit the memory value

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 #6442

Bug 1872644: gherkin script for HPA-add,edit an delete-ODC-3556 #6442

Conversation

sanketpathak commented Aug 25, 2020

gajanan-more left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Aug 26, 2020

gajanan-more left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gajanan-more commented Aug 28, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makambalaji left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makambalaji commented Sep 4, 2020

makambalaji commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020