Bug 1877860: Volume Snapshot basic CRUD tests #6448

cloudbehl · 2020-08-26T12:55:56Z

Signed-off-by: Ankush Behl cloudbehl@gmail.com

spadgett · 2020-08-26T13:26:58Z

/assign @dtaylor113

dtaylor113 · 2020-08-26T13:57:13Z

Hi @cloudbehl are this tests in addition too, and will they impact/conflict with: #6340 ?

bipuladh · 2020-08-26T15:17:03Z

/hold
We need to separate the tests from the Bug fixes.
#6340 also handles CRUD tests of Volume Snapshot already.

cloudbehl · 2020-08-28T07:18:59Z

@dtaylor113 Yes these are additional test which helps generic flows like YAML based creation, edit resource & deletion of the resource.

@bipuladh canceling hold as discussed. The bug is related to tests where YAML creation button was not present & the tests were not getting passed.

/hold cancel

openshift-ci-robot · 2020-09-10T16:06:44Z

@cloudbehl: This pull request references Bugzilla bug 1877860, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1877860: Volume Snapshot basic CRUD tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cloudbehl · 2020-09-10T16:08:40Z

/bugzilla refresh

openshift-ci-robot · 2020-09-10T16:08:48Z

@cloudbehl: This pull request references Bugzilla bug 1877860, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtaylor113 · 2020-09-11T16:32:48Z

Hi @cloudbehl, irt. the changes to Cypress integration test changes in k8-openshift-cruds.spec.ts, those LGTM. I'm not familiar with the other Volume Snapshot changes made.

spadgett · 2020-09-11T17:20:23Z

frontend/public/models/yaml-templates.ts

+apiVersion: snapshot.storage.k8s.io/v1beta1
+kind: VolumeSnapshotContent
+metadata:
+  name: new-snapshot-content-test


Should we have "test" in the name if this is going to be the real volume snapshot template? (Here are elsewhere in the samples.)

We try to make the examples just work if you click save with no changes, but I imagine that's not possible here.

Should we have "test" in the name if this is going to be the real volume snapshot template? (Here are elsewhere in the samples.)

Right, we can call it an example/test. I'll change it.

We try to make the examples just work if you click save with no changes, but I imagine that's not possible here.

I agree, Right now volume snapshots are not adapted to all the storage providers as it's not GA'ed. When snapshot gets GA'ed we should get the default CSI hostpath driver out of the box. So for now just added an example of it as this is provided on k8s documentation as well.

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

cloudbehl · 2020-09-15T16:36:12Z

@spadgett updated the PR please have a look.

spadgett

/lgtm

openshift-bot · 2020-09-19T12:16:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T12:29:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T12:42:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T12:55:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T13:24:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T13:47:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T14:26:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T14:52:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T15:18:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T15:31:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T15:44:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-19T16:36:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

cloudbehl · 2020-09-19T16:42:40Z

/hold needs rebase

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl · 2020-09-21T07:38:05Z

/hold cancel
Rebased the PR!

FYI @spadgett

cloudbehl · 2020-09-23T05:46:59Z

/test e2e-gcp-console
/test images

dtaylor113

/lgtm -thanks

spadgett

/approve

dtaylor113 · 2020-09-23T15:58:36Z

/lgtm

openshift-ci-robot · 2020-09-23T15:58:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cloudbehl, dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-23T19:07:27Z

@cloudbehl: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`d285699`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cloudbehl · 2020-09-23T19:08:21Z

/test e2e-gcp-console

openshift-bot · 2020-09-23T19:22:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-23T19:32:10Z

@cloudbehl: All pull requests linked via external trackers have merged:

openshift/console#6448

Bugzilla bug 1877860 has been moved to the MODIFIED state.

In response to this:

Bug 1877860: Volume Snapshot basic CRUD tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the component/core Related to console core functionality label Aug 26, 2020

openshift-ci-robot requested review from jhadvig and TheRealJon August 26, 2020 12:56

openshift-ci-robot assigned dtaylor113 Aug 26, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2020

cloudbehl force-pushed the snapshot-list-pages branch from 7caccc3 to 53f864a Compare August 28, 2020 07:15

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2020

cloudbehl force-pushed the snapshot-list-pages branch from 53f864a to d2e69d7 Compare September 8, 2020 06:42

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2020

cloudbehl changed the title ~~Volume Snapshot basic CRUD tests~~ Bug 1877860: Volume Snapshot basic CRUD tests Sep 10, 2020

openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 10, 2020

spadgett reviewed Sep 11, 2020

View reviewed changes

cloudbehl force-pushed the snapshot-list-pages branch 2 times, most recently from 75574b9 to dadab2e Compare September 11, 2020 18:32

spadgett approved these changes Sep 18, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2020

Volume Snapshot basic crud test

d285699

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl force-pushed the snapshot-list-pages branch from dadab2e to d285699 Compare September 21, 2020 07:37

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020

dtaylor113 approved these changes Sep 23, 2020

View reviewed changes

spadgett approved these changes Sep 23, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020

openshift-merge-robot merged commit 5be256a into openshift:master Sep 23, 2020

Bug 1877860: Volume Snapshot basic CRUD tests #6448

Bug 1877860: Volume Snapshot basic CRUD tests #6448

Conversation

cloudbehl commented Aug 26, 2020

spadgett commented Aug 26, 2020

dtaylor113 commented Aug 26, 2020

bipuladh commented Aug 26, 2020

cloudbehl commented Aug 28, 2020

openshift-ci-robot commented Sep 10, 2020

cloudbehl commented Sep 10, 2020

openshift-ci-robot commented Sep 10, 2020

dtaylor113 commented Sep 11, 2020

spadgett Sep 11, 2020

Choose a reason for hiding this comment

cloudbehl Sep 11, 2020 • edited

Choose a reason for hiding this comment

cloudbehl commented Sep 15, 2020

spadgett left a comment

Choose a reason for hiding this comment

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

openshift-bot commented Sep 19, 2020

cloudbehl commented Sep 19, 2020

cloudbehl commented Sep 21, 2020 • edited

cloudbehl commented Sep 23, 2020

dtaylor113 left a comment

Choose a reason for hiding this comment

spadgett left a comment

Choose a reason for hiding this comment

dtaylor113 commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

cloudbehl commented Sep 23, 2020

openshift-bot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

cloudbehl Sep 11, 2020 •

edited

cloudbehl commented Sep 21, 2020 •

edited