Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1873147: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests #6455

Merged
merged 1 commit into from Aug 28, 2020
Merged

Bug 1873147: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests #6455

merged 1 commit into from Aug 28, 2020

Conversation

dtaylor113
Copy link
Contributor

@dtaylor113 dtaylor113 commented Aug 26, 2020 •
edited

This will allow us to take advantage of Cypress's new native retry ability which does not work in before/after hooks as shown in this previous message: "Although you have test retries enabled, we do not retry tests when before all or after all hooks fail"

It also helps readability of logs and console output:

  Pod
      ✓ creates the resource instance (9304ms)
      ✓ displays detail view for newly created resource instance (806ms)
      ✓ displays a list view for the resource (3103ms)
      ✓ search view displays created resource instance (3589ms)
      ✓ edits the resource instance (8998ms)
      ✓ deletes the resource instance (13528ms)

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1868724, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868724: cypress crud tests - moved create & delete out of before/after[all] hooks to specific tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 26, 2020
@dtaylor113 dtaylor113 changed the title Bug 1868724: cypress crud tests - moved create & delete out of before/after[all] hooks to specific tests Bug 1868724: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests Aug 26, 2020
@spadgett
Copy link
Member

@bparees FYI, this should remove some of the before all / after all tests you were seeing.

@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1868724, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1868724: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift openshift deleted a comment from openshift-ci-robot Aug 26, 2020
spadgett
spadgett approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 26, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

Hey @dtaylor113, Bug 1868724 is specifically for CI failures due to the logout problem. I'd rather not overload these Bugzilla bugs or we'll get confused. Can you open a separate BZ?

@spadgett spadgett changed the title Bug 1868724: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests Aug 27, 2020
@openshift-ci-robot openshift-ci-robot removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 27, 2020
@dtaylor113 dtaylor113 changed the title cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests Bug 1873147: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests Aug 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 27, 2020
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: This pull request references Bugzilla bug 1873147, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 27, 2020
@openshift openshift deleted a comment from openshift-ci-robot Aug 27, 2020
@openshift openshift deleted a comment from openshift-ci-robot Aug 27, 2020
@dtaylor113
Copy link
Contributor Author

@spadgett, created new BZ -thanks

@spadgett
Copy link
Member

Thanks @dtaylor113 👍

@openshift openshift deleted a comment from openshift-ci-robot Aug 27, 2020
@dtaylor113
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dtaylor113
Copy link
Contributor Author

/retest

2 similar comments
@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2ea7638 into openshift:master Aug 28, 2020
@openshift-ci-robot
Copy link
Contributor

@dtaylor113: All pull requests linked via external trackers have merged:

Bugzilla bug 1873147 has been moved to the MODIFIED state.

In response to this:

Bug 1873147: cypress crud tests - moved create & delete out of before/after[all] hooks and into specific tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 1, 2020
@dtaylor113 dtaylor113 deleted the cypress-crud-refactor branch November 25, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@rhamilto rhamilto Awaiting requested review from rhamilto

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtaylor113 @openshift-ci-robot @spadgett @openshift-bot @openshift-merge-robot