Bug 1874055: report errors when v2v-vmware ConfigMap is not available #6480

atiratree · 2020-08-31T19:17:17Z

either due to permission issues or if missing
show if required ConfigMap attributes are missing per each provider

Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

openshift-ci-robot · 2020-08-31T19:17:24Z

@suomiy: This pull request references Bugzilla bug 1874055, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874055: report errors when v2v-vmware CondifMap is not available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

atiratree · 2020-08-31T19:19:09Z

@irosenzw @glekner @yaacov @matthewcarleton Please review

this PR builds on #6437 and also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1871109

atiratree · 2020-08-31T19:21:06Z

the errors when starting the controller

no permissions:

config map missing

required fields missing (per provider)

RHV/oVirt

vmWare

matthewcarleton · 2020-08-31T19:53:47Z

the errors when starting the controller

no permissions:

It might be more useful to swap the text here. The first thing they'll probably want to see is that they need to contact their admin and then see the info why.

config map missing

Nit: Should say "cannot be found in any of"
General question - will users know what v2v means? is that how it's written in the configmap?

required fields missing (per provider)

RHV/oVirt

No period in title

vmWare

No period in title

I'm not sure we need to hide things in the expand area for these. It seems better to not require the user to click to understand things better IMO.

irosenzw · 2020-09-01T08:55:33Z

frontend/packages/kubevirt-plugin/src/k8s/requests/v2v/start-v2vvmware-controller.ts

+      kubevirtVmwareConfigMap = await getVmwareConfigMap();
+    } catch (error) {
+      if (error?.json.code === 403) {
+        throw new K8sDetailError({


who catches the error ? isn't it the catch in line 169 ?

no, that is just a catch to test the presence of the deployment. The error will get caught in vmware/ovirt provider actions and saved to redux.

- either due to permission issues or if missing - show if required ConfigMap attributes are missing per each provider

atiratree · 2020-09-01T09:33:35Z

fixed the messages

atiratree · 2020-09-01T09:34:31Z

General question - will users know what v2v means? is that how it's written in the configmap?

v2v-vmware is the name of the config map. There is an effort to rename it, but not in this release

atiratree · 2020-09-01T11:09:34Z

I generalized the approach to 403 errors so it can be reused by any user of cleanupAndGetResults

atiratree · 2020-09-01T11:12:09Z

frontend/packages/kubevirt-plugin/src/k8s/requests/cdi-upload/cdi-upload-requests.ts

-  k8sGet: (kind: K8sKind, name: string, namespace: string) => Promise<K8sResourceKind>,
-  counter: number = 30,
-) => {
+const waitForUploadReady = async (dataVolume: K8sResourceKind, counter: number = 30) => {


@glekner I noticed EnhancedK8sMethods are used in cdi upload even though their functionality is never triggered so I reverted back to normal K8s* methods. Let me know if I missed something and they are indeed needed.

...reate-vm-wizard/tabs/import-providers-tab/providers/vm-import-provider-controller-errors.tsx

irosenzw · 2020-09-01T11:24:35Z

...reate-vm-wizard/tabs/import-providers-tab/providers/vm-import-provider-controller-errors.tsx

+  providerType === VMImportProvider.VMWARE ? VMWARE_DOCURL : OVIRT_DOCURL;
+
+const resolveUIMessageTemplating = (message: string, provider: VMImportProvider) => {
+  if (!message) {


if message is null or undefined ?

that shouldn't be an issue as it will just pass through any empty value without a change

frontend/packages/kubevirt-plugin/src/constants/v2v.ts

- add another option to cleanupAndGetResults

irosenzw · 2020-09-02T12:37:14Z

/lgtm

openshift-ci-robot · 2020-09-02T12:37:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-02T14:29:42Z

@suomiy: All pull requests linked via external trackers have merged:

openshift/console#6480

Bugzilla bug 1874055 has been moved to the MODIFIED state.

In response to this:

Bug 1874055: report errors when v2v-vmware ConfigMap is not available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bug 1871109: Add a user friendly error message in VM import wizard

26fb82e

Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com>

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 31, 2020

openshift-ci-robot requested review from pcbailey and rhrazdil August 31, 2020 19:17

openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2020

atiratree mentioned this pull request Aug 31, 2020

bug 1871109: Add a user friendly error message in VM import wizard #6437

Merged

atiratree force-pushed the kv.change-import-error-no-permissions branch from d21f853 to 8ef2dcf Compare August 31, 2020 19:23

atiratree changed the title ~~Bug 1874055: report errors when v2v-vmware CondifMap is not available~~ Bug 1874055: report errors when v2v-vmware ConfigMap is not available Aug 31, 2020

irosenzw reviewed Sep 1, 2020

View reviewed changes

Bug 1874055: report errors when v2v-vmware ConfigMap is not available

3b283e2

- either due to permission issues or if missing - show if required ConfigMap attributes are missing per each provider

atiratree force-pushed the kv.change-import-error-no-permissions branch from 8ef2dcf to 3b283e2 Compare September 1, 2020 09:32

atiratree commented Sep 1, 2020

View reviewed changes

irosenzw reviewed Sep 1, 2020

View reviewed changes

generify 403 errors representation

031814e

- add another option to cleanupAndGetResults

atiratree force-pushed the kv.change-import-error-no-permissions branch from a650afe to 031814e Compare September 1, 2020 11:55

openshift-ci-robot assigned irosenzw Sep 2, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2020

openshift-merge-robot merged commit 879f6cb into openshift:master Sep 2, 2020

spadgett added this to the v4.6 milestone Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1874055: report errors when v2v-vmware ConfigMap is not available #6480

Bug 1874055: report errors when v2v-vmware ConfigMap is not available #6480

atiratree commented Aug 31, 2020

openshift-ci-robot commented Aug 31, 2020

atiratree commented Aug 31, 2020

atiratree commented Aug 31, 2020

matthewcarleton commented Aug 31, 2020 •

edited

irosenzw Sep 1, 2020

atiratree Sep 1, 2020

atiratree commented Sep 1, 2020

atiratree commented Sep 1, 2020

atiratree commented Sep 1, 2020

atiratree Sep 1, 2020

irosenzw Sep 1, 2020

atiratree Sep 1, 2020

irosenzw Sep 1, 2020

irosenzw commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

Bug 1874055: report errors when v2v-vmware ConfigMap is not available #6480

Bug 1874055: report errors when v2v-vmware ConfigMap is not available #6480

Conversation

atiratree commented Aug 31, 2020

openshift-ci-robot commented Aug 31, 2020

atiratree commented Aug 31, 2020

atiratree commented Aug 31, 2020

matthewcarleton commented Aug 31, 2020 • edited

irosenzw Sep 1, 2020

Choose a reason for hiding this comment

atiratree Sep 1, 2020

Choose a reason for hiding this comment

atiratree commented Sep 1, 2020

atiratree commented Sep 1, 2020

atiratree commented Sep 1, 2020

atiratree Sep 1, 2020

Choose a reason for hiding this comment

irosenzw Sep 1, 2020

Choose a reason for hiding this comment

atiratree Sep 1, 2020

Choose a reason for hiding this comment

irosenzw Sep 1, 2020

Choose a reason for hiding this comment

irosenzw commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

openshift-ci-robot commented Sep 2, 2020

matthewcarleton commented Aug 31, 2020 •

edited