Bug 1874817: fixes issue with route creation in case of no ports exposed

[invincibleJai]

Fixes:

• https://issues.redhat.com/browse/ODC-4702
• https://issues.redhat.com/browse/ODC-4701

Analysis / Root cause:

• For Go sample repo builder image is not recommended
• No Route created if user deploys a Go app via Git import flow/Dev catalog

Solution Description:

• Update build-tools to support *.go
• If there are no Ports exposed and use user provided port as target port or default port

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@invincibleJai: This pull request references Bugzilla bug 1874817, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874817: fixes issue with route creation in case of no ports exposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/assign @divyanshiGupta

[divyanshiGupta]

/lgtm

[divyanshiGupta]

/lgtm cancel

[divyanshiGupta]

@invincibleJai I just noticed that if we create a go app using the sample from the new samples catalog then the app is not created since now you have added a check for Source buildStrategy on creation of service and route and thus even when there are no ports and hence no targetPort it tries to create the route and fails.

This can be fixed easily by adding defaultUnknownPort: 8080 to ImportSamplePage form initial-values. Since we are not giving an option for editing route properties here so in case of no ports targetPort is always going to be 8080.

[invincibleJai]

@invincibleJai I just noticed that if we create a go app using the sample from the new samples catalog then the app is not created since now you have added a check for Source buildStrategy on creation of service and route and thus even when there are no ports and hence no targetPort it tries to create the route and fails.

This can be fixed easily by adding defaultUnknownPort: 8080 to ImportSamplePage form initial-values. Since we are not giving an option for editing route properties here so in case of no ports targetPort is always going to be 8080.

Thanks @divyanshiGupta , have updated as suggested

[karthikjeeyar]

Route creation happens successfully now, but while editing the go application I am not able to edit the TargetPort.
While creation i have specified the port as 8081, and during editing i am trying to change it to 8080.

[karthikjeeyar]

Verified locally, Editing targetPort values, route creation and builder image detection for on Golang applications works as expected.
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [invincibleJai]
• frontend/packages/git-service/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@invincibleJai: All pull requests linked via external trackers have merged:

• openshift/console#6494

Bugzilla bug 1874817 has been moved to the MODIFIED state.

In response to this:

Bug 1874817: fixes issue with route creation in case of no ports exposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.