Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1875349: Smoke Test Cases for Monitoring #6510

Merged
merged 1 commit into from Sep 9, 2020
Merged

Bug 1875349: Smoke Test Cases for Monitoring #6510

merged 1 commit into from Sep 9, 2020

Conversation

gajanan-more
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4116

Problem: Gherkin Scripts Design for Monitoring Smoke Test cases

Solution: These are the gherkin scripts designed covering all the scenarios related to Monitoring Smoke Test cases

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 3, 2020
@openshift-ci-robot
Copy link
Contributor

@gajanan-more: This pull request references Bugzilla bug 1875349, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1875349: Smoke Test Cases for Monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/dev-console Related to dev-console labels Sep 3, 2020
@gajanan-more
Copy link
Contributor Author

/assign @sanketpathak @makambalaji

makambalaji
makambalaji reviewed Sep 4, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test data is mandate for all scenarios to make it more useful

...console/integration-tests/features/monitoring/monitoring-Page-Smoke-Metrics-ODC-4116.feature Show resolved Hide resolved
...console/integration-tests/features/monitoring/monitoring-Page-Smoke-Metrics-ODC-4116.feature Outdated Show resolved Hide resolved
...console/integration-tests/features/monitoring/monitoring-Page-Smoke-Metrics-ODC-4116.feature Outdated Show resolved Hide resolved
...console/integration-tests/features/monitoring/monitoring-Page-Smoke-Metrics-ODC-4116.feature Outdated Show resolved Hide resolved
...console/integration-tests/features/monitoring/monitoring-Page-Smoke-Metrics-ODC-4116.feature Outdated Show resolved Hide resolved
...es/dev-console/integration-tests/features/monitoring/monitoring-Tab-Sidebar-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
@gajanan-more gajanan-more force-pushed the monitoring-smoke-odc-4116 branch 2 times, most recently from 497d4b6 to b3dd8e9 Compare September 7, 2020 15:11
makambalaji
makambalaji reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes are missed as per conversation, Please cross check and update the PR once again

...es/dev-console/integration-tests/features/monitoring/monitoring-Tab-Sidebar-ODC-4116.feature Outdated Show resolved Hide resolved
...es/dev-console/integration-tests/features/monitoring/monitoring-Tab-Sidebar-ODC-4116.feature Outdated Show resolved Hide resolved
...es/dev-console/integration-tests/features/monitoring/monitoring-Tab-Sidebar-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
...-console/integration-tests/features/monitoring/monitoringa-Page-Smoke-Tests-ODC-4116.feature Outdated Show resolved Hide resolved
@makambalaji
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1875349, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 9, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4c3536d into openshift:master Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

@gajanan-more: All pull requests linked via external trackers have merged:

Bugzilla bug 1875349 has been moved to the MODIFIED state.

In response to this:

Bug 1875349: Smoke Test Cases for Monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gajanan-more
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@gajanan-more: Bugzilla bug 1875349 is in an unrecognized state (VERIFIED) and will not be moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketpathak sanketpathak sanketpathak left review comments

@makambalaji makambalaji makambalaji left review comments

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@sanketpathak sanketpathak

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gajanan-more @openshift-ci-robot @makambalaji @openshift-bot @sanketpathak @spadgett @openshift-merge-robot