Bug 1850574: add better cloud init message for ovirt import

[atiratree]

No description provided.

[openshift-ci-robot]

@suomiy: This pull request references Bugzilla bug 1850574, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1850574: add better cloud init message for ovirt import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[atiratree]

@matthewcarleton

[matthewcarleton]

thanks @suomiy I think this looks good. I'm asking around for other outside opinions to make sure it makes sense too :)

[matthewcarleton]

@suomiy I had a good chat with some other designers and they made the good point of surfacing this type of message in either the Connect to provider step where it would be more of a general list of things that might not show up. If we did that we could then consider hiding the advanced > cloud init step entirely. WDYT?

[atiratree]

@matthewcarleton I to not think this is a very useful message to have in the connect to provider step. There is already too much happening there. Plus this is very specific

[matthewcarleton]

@suomiy My line of thinking here is that for a user to know as soon as possible where they could see a gap in their expectations and what we have in the wizard.
At the very least changing the title is probably a good idea ( I know I wrote this to begin with haha)

Possible data missing from import
This wizard may not show all data from the import. If data is not showing here view the details of the import after it has completed for a full data set.

[atiratree]

updated the text

please review
@irosenzw @yaacov @glekner @pcbailey

[yaacov]

I assume @matthewcarleton 's 👍 means he approve :-)

/lgtm

[yaacov]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[atiratree]

updated the design

[atiratree]

@yaacov can you relgtm?

[matthewcarleton]

LGTM!

[yaacov]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [suomiy,yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@suomiy: All pull requests linked via external trackers have merged:

• openshift/console#6511

Bugzilla bug 1850574 has been moved to the MODIFIED state.

In response to this:

Bug 1850574: add better cloud init message for ovirt import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.