Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) #6513

abhinandan13jan · 2020-09-03T12:25:07Z

Adresses

https://issues.redhat.com/browse/ODC-4320

Issue

Pipeline Conditions WhiteScreen the Log View

Solution

Added null check

ScreenShot

Tests

Tests unaltered

Browser

Chrome, Firefox

openshift-ci-robot · 2020-09-03T12:25:08Z

@abhinandan13jan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Manual cherrypick fix log whitescreen (release-4.4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-03T12:27:27Z

@abhinandan13jan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Manual cherrypick fix log whitescreen (release-4.4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-03T12:30:59Z

@abhinandan13jan: This pull request references Bugzilla bug 1875381, which is invalid:

expected dependent Bugzilla bug 1867040 to target a release in 4.5.0, 4.5.z, but it targets "4.6.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinandan13jan · 2020-09-03T12:32:26Z

/bugzilla refresh
/kind bug

openshift-ci-robot · 2020-09-03T12:32:34Z

@abhinandan13jan: This pull request references Bugzilla bug 1875381, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1867042 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1867042 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

In response to this:

/bugzilla refresh
/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne

/lgtm

This will be needed for 4.4 to avoid a breaking (whitescreen) functionality in the Console.

andrewballantyne · 2020-09-03T13:29:23Z

/bugzilla refresh

It's actually high severity, updating...

openshift-ci-robot · 2020-09-03T13:29:28Z

@andrewballantyne: This pull request references Bugzilla bug 1875381, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.z) matches configured target release for branch (4.4.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1867042 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1867042 targets the "4.5.z" release, which is one of the valid target releases: 4.5.0, 4.5.z
bug has dependents

In response to this:

/bugzilla refresh

It's actually high severity, updating...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andrewballantyne · 2020-09-03T13:39:55Z

/lgtm cancel

@abhinandan13jan You missed an item: https://github.com/openshift/console/pull/6513/files?file-filters%5B%5D=#diff-ed4cae45a21455c6bb1be585d07cc4e4R60

andrewballantyne · 2020-09-04T14:01:23Z

frontend/packages/dev-console/src/components/pipelineruns/detail-page-tabs/PipelineRunLogs.tsx

    const taskRuns = Object.keys(taskRunFromYaml).sort((a, b) => {
      if (_.get(taskRunFromYaml, [a, 'status', 'completionTime'], false)) {
-        return taskRunFromYaml[b].status.completionTime &&
+        return taskRunFromYaml[b].status?.completionTime &&
          new Date(taskRunFromYaml[a].status.completionTime) >
            new Date(taskRunFromYaml[b].status.completionTime)
          ? 1
          : -1;
      }
      return taskRunFromYaml[b].status.completionTime ||
-        new Date(taskRunFromYaml[a].status.startTime) >
+        new Date(taskRunFromYaml[a].status?.startTime) >
          new Date(taskRunFromYaml[b].status.startTime)
        ? 1


You didn't quite implement this the same way, but I see .startTime is being optional in 4.5 & 4.6

Can we not just mirror what we have there so there are no surprises in this backport. Optionality should be pretty safe here.

From #6053

So the change here is now bigger then the origin PR? I think this one is good, but should we change the master also and replace status.startTime with status?.startTime ?? 🤔

@jerolimov The master works fine and tested well along the scenarios. This is just an overprotection so that things do not break.

changed it to be same as master

I think this is fine... I'll let @jerolimov comment as he had a pending question that he has not responded to the answer.

Its now similar to master so this cherrypick is for me. 👍

abhinandan13jan · 2020-09-09T10:56:50Z

/test frontend

andrewballantyne · 2020-09-09T14:41:54Z

/retest

jerolimov

/lgtm

openshift-ci-robot · 2020-09-09T14:45:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, andrewballantyne, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-10T13:27:51Z

@abhinandan13jan: All pull requests linked via external trackers have merged:

openshift/console#6513

Bugzilla bug 1875381 has been moved to the MODIFIED state.

In response to this:

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from abhi-kn and divyanshiGupta September 3, 2020 12:26

openshift-ci-robot added the component/dev-console Related to dev-console label Sep 3, 2020

abhinandan13jan changed the title ~~Manual cherrypick fix log whitescreen (release-4.4)~~ Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) Sep 3, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 3, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 3, 2020

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 3, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 3, 2020

abhinandan13jan mentioned this pull request Sep 3, 2020

Bug 1867042: fix log completiontime issue #6244

Merged

andrewballantyne approved these changes Sep 3, 2020

View reviewed changes

openshift-ci-robot assigned andrewballantyne Sep 3, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. labels Sep 3, 2020

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2020

abhinandan13jan force-pushed the fix-log-whitescreen branch from 6ef0a4c to 67c9ce2 Compare September 4, 2020 11:28

andrewballantyne reviewed Sep 4, 2020

View reviewed changes

abhinandan13jan force-pushed the fix-log-whitescreen branch from 67c9ce2 to 2b9300b Compare September 7, 2020 12:45

4.4 fix log whitescreen

783b8d9

abhinandan13jan force-pushed the fix-log-whitescreen branch from 948eba3 to 783b8d9 Compare September 9, 2020 11:28

andrewballantyne approved these changes Sep 9, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020

jerolimov approved these changes Sep 9, 2020

View reviewed changes

openshift-ci-robot assigned jerolimov Sep 9, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020

eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 10, 2020

openshift-merge-robot merged commit e93acc0 into openshift:release-4.4 Sep 10, 2020

spadgett added this to the v4.4.z milestone Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) #6513

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) #6513

abhinandan13jan commented Sep 3, 2020 •

edited

openshift-ci-robot commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

abhinandan13jan commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

andrewballantyne left a comment

andrewballantyne commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

andrewballantyne commented Sep 3, 2020

andrewballantyne Sep 4, 2020

abhinandan13jan Sep 7, 2020

jerolimov Sep 7, 2020

abhinandan13jan Sep 8, 2020

abhinandan13jan Sep 9, 2020

andrewballantyne Sep 9, 2020

jerolimov Sep 9, 2020

abhinandan13jan commented Sep 9, 2020

andrewballantyne commented Sep 9, 2020

jerolimov left a comment

openshift-ci-robot commented Sep 9, 2020

openshift-ci-robot commented Sep 10, 2020

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) #6513

Bug 1875381: Manual cherrypick fix log whitescreen (release-4.4) #6513

Conversation

abhinandan13jan commented Sep 3, 2020 • edited

Adresses

Issue

Solution

ScreenShot

Tests

Browser

openshift-ci-robot commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

abhinandan13jan commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

andrewballantyne left a comment

Choose a reason for hiding this comment

andrewballantyne commented Sep 3, 2020

openshift-ci-robot commented Sep 3, 2020

andrewballantyne commented Sep 3, 2020

andrewballantyne Sep 4, 2020

Choose a reason for hiding this comment

abhinandan13jan Sep 7, 2020

Choose a reason for hiding this comment

jerolimov Sep 7, 2020

Choose a reason for hiding this comment

abhinandan13jan Sep 8, 2020

Choose a reason for hiding this comment

abhinandan13jan Sep 9, 2020

Choose a reason for hiding this comment

andrewballantyne Sep 9, 2020

Choose a reason for hiding this comment

jerolimov Sep 9, 2020

Choose a reason for hiding this comment

abhinandan13jan commented Sep 9, 2020

andrewballantyne commented Sep 9, 2020

jerolimov left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 9, 2020

openshift-ci-robot commented Sep 10, 2020

abhinandan13jan commented Sep 3, 2020 •

edited