New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1875702: Add test to check network supported models #6525
Conversation
Hi @gouyang. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -123,6 +124,16 @@ describe('Test network type presets and options', () => { | |||
const wizard = new Wizard(); | |||
const leakedResources = new Set<string>(); | |||
|
|||
const fillGeneralStep = async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could go a bit further. Can we split the processWizard logic into the steps and call processGeneralStep here instead?
we can also use getBasicVMBuilder() or one of the presets here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
@@ -123,6 +124,15 @@ describe('Test network type presets and options', () => { | |||
const wizard = new Wizard(); | |||
const leakedResources = new Set<string>(); | |||
|
|||
const vm = new VMBuilder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is easier to use getBasicVMBuilder here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use getBasicVMBuilder here now.
@gouyang: This pull request references Bugzilla bug 1875702, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gouyang: All pull requests linked via external trackers have merged: Bugzilla bug 1875702 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add test to check network supported models are virtio and e1000e.
Add test to check model is disabled when sriov is selected.
Implementation for:
https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-4780
https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-4781