New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1866315: Inconsistent naming in storage cluster creation #6540
Bug 1866315: Inconsistent naming in storage cluster creation #6540
Conversation
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
@cloudbehl: This pull request references Bugzilla bug 1866315, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
label: 'OCS Cluster Service', | ||
labelPlural: 'OCS Cluster Services', | ||
label: 'Storage Cluster', | ||
labelPlural: 'Storage Clusters', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not change abbr -> SC ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even, id can be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SC is a storage class so make sense to have OCS
as it differentiates.
Id is internal and is not used to display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I am assuming to have Storage Cluster model be aligned to its CRD spec.
Therefore changing abbr and id makes sense .
Also, we have Portworx operator which has Storage Cluster as API and it represents SC only in console.
So are we overriding intentionally the common pattern @cloudbehl ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Abbr and id are specific to UI only and not related to CRD spec. This is used to override the default functionality.
I'm good making it default but I found OCS more relevant & unique as an abbr. So Let me know your thoughts & I'll change it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, for this bug fix lets have the current change in and we can discuss over other changes offline.
Thanks!
/lgtm cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh, cloudbehl, gnehapk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cloudbehl: All pull requests linked via external trackers have merged: Bugzilla bug 1866315 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Ankush Behl cloudbehl@gmail.com