Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1876741: undo filtering of incompatible helm charts #6550

Merged
merged 1 commit into from Sep 10, 2020
Merged

Bug 1876741: undo filtering of incompatible helm charts #6550

merged 1 commit into from Sep 10, 2020

Conversation

debsmita1
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-4746
reverts changes made in #5767

Root Analysis:

  • version range >=1.10.11 is not compatible with pre-released versions like v1.10.11-rc.2+068702d
  • version range >=1.10.11-0 only accepts prerelease tags on the version 1.10.11 like v1.10.11-rc.2+068702d & not v1.17.3-rc.2+0687785

Before Change:
before

After Change:
after

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console labels Sep 8, 2020
@debsmita1
Copy link
Contributor Author

/kind bug
/assign @rohitkrai03

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2020
@abhinandan13jan
Copy link
Contributor

abhinandan13jan commented Sep 9, 2020 •
edited

just a reminder. We do need a bug for this. Overall the changes look good. haven't tested locally

@debsmita1 debsmita1 changed the title undo filtering of incompatible helm charts Bug 1876741: undo filtering of incompatible helm charts Sep 9, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 9, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: This pull request references Bugzilla bug 1876741, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1876741: undo filtering of incompatible helm charts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 9, 2020
@nemesis09
Copy link
Contributor

tested locally. charts show up as expected.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2020
rohitkrai03
rohitkrai03 approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, nemesis09, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 84e7fc1 into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@debsmita1: All pull requests linked via external trackers have merged:

Bugzilla bug 1876741 has been moved to the MODIFIED state.

In response to this:

Bug 1876741: undo filtering of incompatible helm charts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@nemesis09 nemesis09 Awaiting requested review from nemesis09

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rohitkrai03 rohitkrai03

@nemesis09 nemesis09

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@debsmita1 @abhinandan13jan @openshift-ci-robot @nemesis09 @rohitkrai03 @spadgett @openshift-merge-robot