Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1870339: Sets volumeMode as block for RBD+RWX #6559

Merged
merged 1 commit into from Sep 25, 2020
Merged

Bug 1870339: Sets volumeMode as block for RBD+RWX #6559

merged 1 commit into from Sep 25, 2020

Conversation

a2batic
Copy link
Contributor

@a2batic a2batic commented Sep 8, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 8, 2020
@openshift-ci-robot
Copy link
Contributor

@a2batic: This pull request references Bugzilla bug 1870339, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870339: Sets volumeMode as block for RBD+RWX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 8, 2020
@a2batic
Copy link
Contributor Author

a2batic commented Sep 8, 2020

/assign @rawagner

@cloudbehl
Copy link
Contributor

The Ideal way to figure out the weather its block or filesystem will be to get the PVC data & see the access mode. Let's not hardcode it.

@openshift-ci-robot
Copy link
Contributor

@a2batic: This pull request references Bugzilla bug 1870339, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870339: Sets volumeMode as block for RBD+RWX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2020
@a2batic
Copy link
Contributor Author

a2batic commented Sep 22, 2020

/test frontend

1 similar comment
@a2batic
Copy link
Contributor Author

a2batic commented Sep 22, 2020

/test frontend

@a2batic
Copy link
Contributor Author

a2batic commented Sep 22, 2020

/assign @spadgett

@a2batic
Copy link
Contributor Author

a2batic commented Sep 23, 2020

/test frontend

@openshift-ci-robot
Copy link
Contributor

@a2batic: This pull request references Bugzilla bug 1870339, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1870339: Sets volumeMode as block for RBD+RWX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett
spadgett reviewed Sep 23, 2020
View reviewed changes
frontend/packages/console-app/src/components/modals/restore-pvc/restore-pvc-modal.tsx Outdated
// should set block only for RBD + RWX
if (
_.endsWith(snapshotClassResource?.driver, cephRBDProvisionerSuffix) &&
accessModes[0] === 'ReadWriteMany'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with the PVC API, but we need to check if any of the array items are ReadWriteMany? Or that there is only one item in the array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spadgett yes a PVC can have only 1 access mode at a time https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, maybe I missed it, but I don't see where the link says there can only be one. (I'm also unsure why it would be an array in the API in that case.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my understanding: There can be multiple-access modes for a PV but when the PV is mounted using PVC there will be only one access mode that will be used. So we can assume that only one value will exist at a time. (I.e only fits for Static PV creation)

It's the same reason we have radio buttons for access mode while PVC creation.

Copy link
Contributor Author

@a2batic a2batic Sep 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @spadgett @cloudbehl , the link says the Important! A volume can only be mounted using one access mode at a time, even if it supports many. But, PVC CR lets you create PVC with multiple access modes, so +1, we should handle it. Updated the PR to check in the array. Sorry for the confusion.

Bug 1870339: Sets volumeMode as block for RBD+RWX
f43d598 
Signed-off-by: Kanika Murarka <kmurarka@redhat.com>
@a2batic
Copy link
Contributor Author

a2batic commented Sep 24, 2020

/test e2e-gcp-console

1 similar comment
@a2batic
Copy link
Contributor Author

a2batic commented Sep 24, 2020

/test e2e-gcp-console

@a2batic
Copy link
Contributor Author

a2batic commented Sep 24, 2020

@spadgett addressed comments, please review.

spadgett
spadgett approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, cloudbehl, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 20b95e6 into openshift:master Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@a2batic: All pull requests linked via external trackers have merged:

Bugzilla bug 1870339 has been moved to the MODIFIED state.

In response to this:

Bug 1870339: Sets volumeMode as block for RBD+RWX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 left review comments

@bipuladh bipuladh bipuladh requested changes

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@spadgett spadgett

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@a2batic @openshift-ci-robot @cloudbehl @spadgett @Madhu-1 @bipuladh @rawagner @openshift-merge-robot