Bug 1877944: Show all resources for selected operator in the topology side panel #6591
Conversation
openshift-ci-robot
requested review from
beaumorley,
bgliwa01 and
serenamarie125
openshift-ci-robot
added
the
kind/bug
|
@jeff-phillips-18: This pull request references Bugzilla bug 1877944, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
/retest |
|
/retest |
openshift-ci-robot
added
the
needs-rebase
jeff-phillips-18
force-pushed
the
operator-side-panel
branch
from
946f7c9
to
d33e4a3
Compare
openshift-ci-robot
removed
the
needs-rebase
jeff-phillips-18
force-pushed
the
operator-side-panel
branch
from
d33e4a3
to
49cb122
Compare
| @@ -6,7 +6,8 @@ import { ClusterServiceVersionModel } from '../../models'; | |||
|
|
|||
| export const OperandLink: React.SFC<OperandLinkProps> = (props) => { | |||
| const { namespace, name } = props.obj.metadata; | |||
| const csvName = () => | |||
| const csvName = | |||
| props.csvName || | |||
There was a problem hiding this comment.
not part of this PR but would be good to use csvNameFromWindow here for || condition
| return ( | ||
| <StatusBox data={manifestResources} loaded={loaded} loadError={loadError} label="Resources"> | ||
| <TopologyGroupResourcesPanel | ||
| manifestResources={flatten(resources)} |
There was a problem hiding this comment.
in line 45 https://github.com/openshift/console/pull/6591/files#diff-fd65de433ab9e684dee076b3cc686df8R45, we have it it in const , can we use that?
| resources, | ||
| loaded, | ||
| loadError, | ||
| flatten, |
There was a problem hiding this comment.
just thought , why are we passing flatten as props across , can't we just use util flattenCsvResources wherever needed?
There was a problem hiding this comment.
flatten is a function returned from a call to flattenCsvResources on line https://github.com/openshift/console/pull/6591/files#diff-fd65de433ab9e684dee076b3cc686df8R122
jeff-phillips-18
force-pushed
the
operator-side-panel
branch
from
49cb122
to
17c9094
Compare
|
@jeff-phillips-18 Thanks , looks good overall. In below scenario for
|
|
@invincibleJai The side panel reuses code to show the same resources as instance's details page resources tab so I believe this PR to be correct. We should determine which is correct, topology or the details resource listing. I've added https://issues.redhat.com/browse/ODC-4886 to address that issue. |
|
/lgtm |
|
/assign @christianvogt |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgliwa01, christianvogt, invincibleJai, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jeff-phillips-18: All pull requests linked via external trackers have merged: Bugzilla bug 1877944 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes
https://issues.redhat.com/browse/ODC-4470
Description
Adds a managed by link and all the operator associated resources to the resources tab in the side panel in topology.
Screenshots
Browser conformance:
/kind bug
/cc @bgliwa01 @beaumorley @serenamarie125