Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1863402: Fix for Developer console tables show extra columns due to column management #6601

Merged
merged 1 commit into from Sep 12, 2020
Merged

Bug 1863402: Fix for Developer console tables show extra columns due to column management #6601

merged 1 commit into from Sep 12, 2020

Conversation

jcaianirh
Copy link
Member

Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1863402

Make sure to disable column management features for dev project table

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: This pull request references Bugzilla bug 1863402, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1863402: Fix for Developer console tables show extra columns due to column management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Sep 11, 2020
spadgett
spadgett approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@jcaianirh
Copy link
Member Author

/retest

@spadgett spadgett mentioned this pull request Sep 12, 2020
Closed
@spadgett
Copy link
Member

/retest

1 similar comment
@jcaianirh
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 034f5ed into openshift:master Sep 12, 2020
@openshift-ci-robot
Copy link
Contributor

@jcaianirh: All pull requests linked via external trackers have merged:

Bugzilla bug 1863402 has been moved to the MODIFIED state.

In response to this:

Bug 1863402: Fix for Developer console tables show extra columns due to column management

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcaianirh @openshift-ci-robot @spadgett @openshift-merge-robot