Bug 1877728: Fixes bug attaching block storage to pods, deployments in attach-storage page #6609
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@vbnrh: This pull request references Bugzilla bug 1877728, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
component/core
|
/assign clouldbehl |
|
@vbnrh: GitHub didn't allow me to assign the following users: clouldbehl. Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| const PVCDropdown: React.FC<PVCDropdownProps> = (props) => { | ||
| const kind = 'PersistentVolumeClaim'; | ||
| const { namespace, selectedKey } = props; | ||
| const resources = [{ kind, namespace }]; | ||
| return ( | ||
| <ListDropdown | ||
| {...props} | ||
| desc="Persistent Volume Claim" | ||
| resources={resources} | ||
| selectedKeyKind={kind} | ||
| placeholder="Select claim" | ||
| selectedKey={selectedKey} | ||
| /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Why introduce new changes for 4.5? Use the PVCDropdown from this file itself. we don't need to refactor in this PR.
There was a problem hiding this comment.
I had added that for the type checks. I have reverted to use this itself. Thanks
vbnrh
force-pushed
the
cp-6221-r4.5
branch
2 times, most recently
from
b00733b
to
57ae186
Compare
…age page Using block storage provisioners with RWX access mode incorrectly attaches the path as volumeMount in PodSpec instead of volumeDevice. This caused the pods to be in a state of ContainerCreation indefinitely. This commit fixes this by sending the object with the right configuration for block storage. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1853599 Signed-off-by: Vineet Badrinath <vbadrina@redhat.com>
|
@spadgett Please review. |
|
Will review once approved |
|
@ashcrow PR is approved, thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cloudbehl, spadgett, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ashcrow
added
the
cherry-pick-approved
|
@vbnrh: All pull requests linked via external trackers have merged: Bugzilla bug 1877728 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using block storage provisioners with RWX access mode incorrectly attaches the path as volumeMount in PodSpec instead of volumeDevice. This caused the pods to be in a state of ContainerCreation indefinitely. This commit fixes this by sending the object with the right configuration for block storage.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1877728
Signed-off-by: Vineet Badrinath vbadrina@redhat.com