New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1880118: Cypress better headless logging #6629
Bug 1880118: Cypress better headless logging #6629
Conversation
/retest |
Hey, @dtaylor113. Are you concerned with running headless in CI or running headless locally? To be honest, I prefer the current behavior. I find it confusing to interleave the log messages and test results in the console. |
Adding the log msgs to the output allowed me to discover a flake and IMO really helps see what is occuring so that when a failure happens I can clearly and quickly see the last log message. |
0abf15a
to
c0d3024
Compare
Hi @spadgett , indented the log messages so that the test names stands out more:
|
@dtaylor113: This pull request references Bugzilla bug 1880118, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c0d3024
to
9f8f29d
Compare
frontend/packages/integration-tests-cypress/reporter-config.json
Outdated
Show resolved
Hide resolved
9f8f29d
to
66a08e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dtaylor113: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1880118 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR improves logging in headless mode. Cypress best-practice of test independence results in larger independent tests, as opposed to previously many small dependent tests. In headless mode, cypress only outputs the test names as they run; as a result of fewer tests, there isn't a lot of output:
BEFORE
In the gui Cypress Test Runner we use
cy.log(...)
's to help determine test progression:This PR exports these
cy.log
messages to headless terminal output, as well as improving logging messages:AFTER
*
These log messages will only appear after #6628 merges (flake)!In addition this PR:
[mochawesome] Report JSON saved to /home/dtaylor/repos/openshift/origin/src/github.com/openshift/console/frontend/gui_test_screenshots/cypress_report_004.json
outputgui_test_screenshots
dir