Bug 1871736: Fixes clone for block mode PVCs #6630

a2batic · 2020-09-15T14:22:39Z

Replace the constants with shared constants.
Sets volumeMode while creating clone
Disable the clone and snapshot actions for unbound PVCs and restore action for non-ready snapshots

Signed-off-by: Kanika Murarka kmurarka@redhat.com

openshift-ci-robot · 2020-09-15T14:22:45Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-09-15T14:39:20Z

/assign @cloudbehl @gnehapk

spadgett · 2020-09-15T14:42:02Z

We typically disable the action in the action menu instead of letting users open the dialog and immediately see an error.

openshift-ci-robot · 2020-09-15T17:32:37Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-15T20:33:07Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-15T20:37:28Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gnehapk · 2020-09-16T01:59:51Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

@@ -54,6 +43,9 @@ const ClonePVCModal = withHandlePromise((props: ClonePVCModalProps) => {
  const [clonePVCName, setClonePVCName] = React.useState(`${pvcName}-clone`);
  const [requestedSize, setRequestedSize] = React.useState(defaultSize[0] || '');
  const [requestedUnit, setRequestedUnit] = React.useState(defaultSize[1] || 'Gi');
+  const accessModes = accessModeRadios.find(


accessModes -> accessMode

gnehapk · 2020-09-16T02:01:43Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

@@ -164,7 +157,7 @@ const ClonePVCModal = withHandlePromise((props: ClonePVCModalProps) => {
              <div>
                <div>
                  <p className="co-clone-pvc-modal__pvc-details">Access Mode</p>
-                  <p>{accessModeLabels[resource.spec.accessModes]}</p>
+                  <p>{accessModes.title}</p>


what happen when accessMode is undefined i.e. the search accessMode is not present?

ack, I have handled it

openshift-ci-robot · 2020-09-16T12:35:41Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-09-16T12:35:52Z

/assign @spadgett

a2batic · 2020-09-16T13:31:28Z

/test e2e-gcp-console

a2batic · 2020-09-16T14:03:30Z

/test e2e-gcp-console

a2batic · 2020-09-16T15:26:26Z

/test e2e-gcp-console

cloudbehl · 2020-09-17T06:05:53Z

frontend/public/components/utils/kebab.tsx

@@ -350,6 +354,8 @@ const kebabFactory: KebabFactory = {
  }),
  RestorePVC: (kind, obj) => ({
    label: 'Restore as new PVC',
+    isDisabled: obj?.status?.phase !== 'Ready',
+    tooltip: obj?.status?.phase !== 'Ready' ? 'Snapshot is not Ready' : '',


Suggested change

tooltip: obj?.status?.phase !== 'Ready' ? 'Snapshot is not Ready' : '',

tooltip: obj?.status?.phase !== 'Ready' ? 'Volume Snapshot is not Ready' : '',

cloudbehl · 2020-09-17T06:06:02Z

frontend/public/components/utils/kebab.tsx

    href: `${resourceObjPath(obj, kind.crd ? referenceForModel(kind) : kind.kind)}/${
      VolumeSnapshotModel.plural
    }/~new/form`,
    accessReview: asAccessReview(kind, obj, 'create'),
  }),
  ClonePVC: (kind, obj) => ({
    label: 'Clone PVC',
+    isDisabled: obj?.status?.phase !== 'Bound',
+    tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not bound' : '',


Suggested change

tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not bound' : '',

tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not Bound' : '',

cloudbehl · 2020-09-17T06:06:11Z

frontend/public/components/utils/kebab.tsx

@@ -334,13 +334,17 @@ const kebabFactory: KebabFactory = {
  }),
  PVCSnapshot: (kind, obj) => ({
    label: 'Create Snapshot',
+    isDisabled: obj?.status?.phase !== 'Bound',
+    tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not bound' : '',


Suggested change

tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not bound' : '',

tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not Bound' : '',

openshift-ci-robot · 2020-09-18T08:41:41Z

@a2batic: This pull request references Bugzilla bug 1871736, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-09-18T09:13:56Z

@rawagner, please review/
/assign @rawagner

spadgett

/lgtm

spadgett · 2020-09-18T16:34:08Z

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

@@ -75,7 +67,7 @@ const ClonePVCModal = withHandlePromise((props: ClonePVCModalProps) => {
  const submit = (event: React.FormEvent<EventTarget>) => {
    event.preventDefault();

-    const pvcCloneObj = {
+    const pvcCloneObj: PersistentVolumeClaimKind = {


spadgett · 2020-09-18T16:34:32Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

@@ -200,6 +200,8 @@ const CreateSnapshotForm = withHandlePromise<SnapshotResourceProps>((props) => {
    });
  };

+  const pvcFilter = (pvc: PersistentVolumeClaimKind) => pvc?.status?.phase === 'Bound';


Suggested change

const pvcFilter = (pvc: PersistentVolumeClaimKind) => pvc?.status?.phase === 'Bound';

const isBound = (pvc: PersistentVolumeClaimKind) => pvc?.status?.phase === 'Bound';

spadgett · 2020-09-18T16:34:51Z

...console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

@@ -231,6 +225,7 @@ const CreateSnapshotForm = withHandlePromise<SnapshotResourceProps>((props) => {
              namespace={namespace}
              onChange={handlePVCName}
              selectedKey={pvcName}
+              dataFilter={pvcFilter}


Signed-off-by: Kanika Murarka <kmurarka@redhat.com>

a2batic · 2020-09-18T18:27:39Z

/retest

spadgett

/lgtm

openshift-ci-robot · 2020-09-18T18:28:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, cloudbehl, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-18T22:38:03Z

@a2batic: All pull requests linked via external trackers have merged:

openshift/console#6630

Bugzilla bug 1871736 has been moved to the MODIFIED state.

In response to this:

Bug 1871736: Fixes clone for block mode PVCs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 15, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 15, 2020

openshift-ci-robot requested review from jcaianirh and zherman0 September 15, 2020 14:22

openshift-ci-robot added the component/core Related to console core functionality label Sep 15, 2020

openshift-ci-robot assigned cloudbehl and gnehapk Sep 15, 2020

a2batic force-pushed the clone branch from 34ef6fa to 57d5969 Compare September 15, 2020 17:31

a2batic force-pushed the clone branch 2 times, most recently from 0f6aefa to 8bdfde4 Compare September 15, 2020 20:36

gnehapk reviewed Sep 16, 2020

View reviewed changes

a2batic force-pushed the clone branch from 8bdfde4 to a8ea197 Compare September 16, 2020 12:34

openshift-ci-robot assigned spadgett Sep 16, 2020

a2batic requested a review from gnehapk September 16, 2020 13:31

cloudbehl reviewed Sep 17, 2020

View reviewed changes

a2batic force-pushed the clone branch from a8ea197 to b980dd5 Compare September 18, 2020 08:40

cloudbehl approved these changes Sep 18, 2020

View reviewed changes

a2batic force-pushed the clone branch from b980dd5 to 652dae5 Compare September 18, 2020 09:08

openshift-ci-robot assigned rawagner Sep 18, 2020

spadgett approved these changes Sep 18, 2020

View reviewed changes

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2020

Bug 1871736: Fixes clone for block mode PVCs

879f4d5

Signed-off-by: Kanika Murarka <kmurarka@redhat.com>

a2batic force-pushed the clone branch from 652dae5 to 879f4d5 Compare September 18, 2020 18:08

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020

spadgett approved these changes Sep 18, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020

openshift-merge-robot merged commit 0901e45 into openshift:master Sep 18, 2020

spadgett added this to the v4.6 milestone Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1871736: Fixes clone for block mode PVCs #6630

Bug 1871736: Fixes clone for block mode PVCs #6630

a2batic commented Sep 15, 2020 •

edited

openshift-ci-robot commented Sep 15, 2020

a2batic commented Sep 15, 2020

spadgett commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

gnehapk Sep 16, 2020

gnehapk Sep 16, 2020

a2batic Sep 18, 2020

openshift-ci-robot commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

cloudbehl Sep 17, 2020

cloudbehl Sep 17, 2020

cloudbehl Sep 17, 2020

openshift-ci-robot commented Sep 18, 2020

a2batic commented Sep 18, 2020

spadgett left a comment

spadgett Sep 18, 2020

spadgett Sep 18, 2020

spadgett Sep 18, 2020

a2batic commented Sep 18, 2020

spadgett left a comment

openshift-ci-robot commented Sep 18, 2020

openshift-ci-robot commented Sep 18, 2020

	tooltip: obj?.status?.phase !== 'Ready' ? 'Snapshot is not Ready' : '',
	tooltip: obj?.status?.phase !== 'Ready' ? 'Volume Snapshot is not Ready' : '',

	tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not bound' : '',
	tooltip: obj?.status?.phase !== 'Bound' ? 'PVC is not Bound' : '',

	const pvcFilter = (pvc: PersistentVolumeClaimKind) => pvc?.status?.phase === 'Bound';
	const isBound = (pvc: PersistentVolumeClaimKind) => pvc?.status?.phase === 'Bound';

Bug 1871736: Fixes clone for block mode PVCs #6630

Bug 1871736: Fixes clone for block mode PVCs #6630

Conversation

a2batic commented Sep 15, 2020 • edited

openshift-ci-robot commented Sep 15, 2020

a2batic commented Sep 15, 2020

spadgett commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

openshift-ci-robot commented Sep 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

a2batic commented Sep 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 18, 2020

a2batic commented Sep 18, 2020

spadgett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

a2batic commented Sep 18, 2020

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 18, 2020

openshift-ci-robot commented Sep 18, 2020

a2batic commented Sep 15, 2020 •

edited