Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1879580: gherkin updation- ux enhancement from bugs #6640

Merged
merged 1 commit into from Oct 2, 2020
Merged

Bug 1879580: gherkin updation- ux enhancement from bugs #6640

merged 1 commit into from Oct 2, 2020

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Sep 16, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Sep 16, 2020
@sanketpathak sanketpathak force-pushed the gherkin-bug-enhancement branch 2 times, most recently from 2257c19 to 5955087 Compare September 16, 2020 14:37
@sanketpathak sanketpathak changed the title gherkin updation- ux enhancement from bugs Bug 1879580: gherkin updation- ux enhancement from bugs Sep 16, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Bugzilla bug 1879580, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879580: gherkin updation- ux enhancement from bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gajanan-more
gajanan-more suggested changes Sep 17, 2020
View reviewed changes
.../packages/dev-console/integration-tests/features/topology/topology-chart_area_visual.feature

@regression
Scenario: Topology filter by resource: T-07-TC06, T-07-TC07
Given user created two workloads with resource type "Deployment" and "Deployment-Config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this in the background?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because other test cases have different given condition

.../packages/dev-console/integration-tests/features/topology/topology-chart_area_visual.feature Outdated Show resolved Hide resolved
frontend/packages/dev-console/integration-tests/features/topology/topology-list_view.feature Outdated
Comment on lines 18 to 25
Given user created two workloads with resource type "Deployment" and "Deployment-Config"
When user clicks on List view button
And user clicks the filter by resource on top
And user will see "Deployment" and "Deployment-Config" options with '1' associated with it
And user clicks on Deployment
And user can see only the deployment workload
And user clicks on Deployment-Config
Then user can see only the deployment-config workload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above
For given statement, can we add it in background
Add empty new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because other test case has different given condition

@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
makambalaji
makambalaji reviewed Sep 22, 2020
View reviewed changes
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add or modify the test cases related to below bugs
ODC-4447 - Application drop down related test case is not available,
ODC-3696 - Set Traffic should not allow the user to specify the same revision twice
ODC-4514 - inconsistent pod donut text for knative service
ODC-4384
ODC-4448
ODC-4222
ODC-3759
ODC-3149

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@makambalaji
Copy link
Contributor

please add or modify the test cases related to below bugs
ODC-4447 - Application drop down related test case is not available,
ODC-3696 - Set Traffic should not allow the user to specify the same revision twice
ODC-4514 - inconsistent pod donut text for knative service
ODC-4384
ODC-4448
ODC-4222
ODC-3759
ODC-3149

please update the scenarios for above bugs as well

@makambalaji
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d3fa4db into openshift:master Oct 2, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: All pull requests linked via external trackers have merged:

Bugzilla bug 1879580 has been moved to the MODIFIED state.

In response to this:

Bug 1879580: gherkin updation- ux enhancement from bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makambalaji makambalaji makambalaji left review comments

@gajanan-more gajanan-more gajanan-more approved these changes

@abhi-kn abhi-kn Awaiting requested review from abhi-kn

Assignees

@gajanan-more gajanan-more

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sanketpathak @openshift-ci-robot @gajanan-more @makambalaji @openshift-bot @spadgett @openshift-merge-robot