Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1879054: UI should display password in cloud-init #6643

Merged
merged 1 commit into from Sep 18, 2020
Merged

Bug 1879054: UI should display password in cloud-init #6643

merged 1 commit into from Sep 18, 2020

Conversation

glekner
Copy link
Contributor

@glekner glekner commented Sep 16, 2020

Added label with the password to the right of the new window button.
The label will only be present if a password is found in the YAML.
thoughts @jelkosz @matthewcarleton ?

image

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: This pull request references Bugzilla bug 1879054, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1879054: UI should display password in cloud-init

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Sep 16, 2020
@jelkosz
Copy link

jelkosz commented Sep 16, 2020

2 things:
1: we need to provide both username and password. If the "user" is not set, the username and the password is the same. But if it looks e.g. like this:
#cloud-config
user: admin
password: q1w2e3
chpasswd: {expire: False}
ssh_pwauth: True
than the user is admin

2: you have to show the password only after the user chooses to. @matthewcarleton @yfrimanm WDYT?

@glekner glekner force-pushed the fix-1879054 branch 2 times, most recently from dd0cd76 to 0e87d60 Compare September 16, 2020 11:32
@glekner
Copy link
Contributor Author

glekner commented Sep 16, 2020

Added user, and to show the password you now have to click Show Password

image

@glekner
Copy link
Contributor Author

glekner commented Sep 16, 2020

image

@jelkosz @matthewcarleton

@jelkosz
Copy link

jelkosz commented Sep 16, 2020

@glekner
1: the "if it is not successful" needs to have a capital "I"
2: once you hit "show password", you need to have also a "hide password" to hide it again

other than that work very nice!

@matthewcarleton
Copy link
Contributor

matthewcarleton commented Sep 16, 2020 •
edited

image

@jelkosz @matthewcarleton

sorry small text tweak:

The following credentials for this operating system were created via Cloud-init. If unsuccessful cloud-init could be improperly configured. Please contact the image provider for more information.

https://xd.adobe.com/view/d972d192-59b8-41fe-8ece-7ce9b3e3a71f-8c21/

@glekner
Copy link
Contributor Author

glekner commented Sep 17, 2020

fixed text and added Hide password button

@yaacov
Copy link
Member

yaacov commented Sep 17, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit bd16afc into openshift:master Sep 18, 2020
@openshift-ci-robot
Copy link
Contributor

@glekner: All pull requests linked via external trackers have merged:

Bugzilla bug 1879054 has been moved to the MODIFIED state.

In response to this:

Bug 1879054: UI should display password in cloud-init

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 23, 2020
Merged
@spadgett spadgett added this to the v4.6 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@yaacov yaacov Awaiting requested review from yaacov

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@glekner @openshift-ci-robot @jelkosz @matthewcarleton @yaacov @openshift-bot @spadgett @openshift-merge-robot